Skip to content

Commit

Permalink
Reimplement DacStackReferenceWalker and DacHandleWalker (#83836)
Browse files Browse the repository at this point in the history
* Refactor DacStackReferenceWalker

Added a flag to not resolve interior pointers to the start of the object. This allows the debugger to shoulder that burden instead of the dac doing this work. This greatly speeds up stack root walking.

Greatly simplified the logic. There's a memory error in this code lurking somewhere because it used some complicated pointer arithmetic that wasn't correct. Since copying references isn't time critical code, I made this as dead simple as possible so it's easy to validate.

* Clean up and simplify DacHandleWalker

* Minor fixes

* Only produce SOS style reference lists

* Fix build warnings

* Fix handle walking issue

* Fix minor handle walking issue
  • Loading branch information
leculver authored Mar 28, 2023
1 parent 531bf3c commit 49ae58a
Show file tree
Hide file tree
Showing 5 changed files with 388 additions and 655 deletions.
Loading

0 comments on commit 49ae58a

Please sign in to comment.