Skip to content

Commit

Permalink
ILVerify after kept member validation (#99914)
Browse files Browse the repository at this point in the history
- ILVerify will fail due to members not being kept, so to make the
  errors more informative, run kept member validation first, then
  ILVerify
  • Loading branch information
jtschuster authored Mar 18, 2024
1 parent 21cfd9f commit aea3682
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ public virtual void Check (TrimmedTestCaseResult linkResult)
if (!HasActiveSkipKeptItemsValidationAttribute(linkResult.TestCase.FindTypeDefinition (original))) {
CreateAssemblyChecker (original, linked, linkResult).Verify ();
}
CreateILChecker ().Check(linkResult, original);
}

VerifyLinkingOfOtherAssemblies (original);
Expand Down Expand Up @@ -279,7 +280,6 @@ protected virtual void AdditionalChecking (TrimmedTestCaseResult linkResult, Ass

protected virtual void InitialChecking (TrimmedTestCaseResult linkResult, AssemblyDefinition original, AssemblyDefinition linked)
{
CreateILChecker ().Check(linkResult, original);
ValidateTypeRefsHaveValidAssemblyRefs (linked);
}

Expand Down

0 comments on commit aea3682

Please sign in to comment.