Skip to content

Commit

Permalink
Initialize m_fInPlaceSS (#109008)
Browse files Browse the repository at this point in the history
A recent fix added a new field to the DebuggerPatchSkip object and missed initializing it false. This causes the new in-place patch skipping logic activate at random depending on the value of uninitialized memory. Fixing this by initializing the variable.
  • Loading branch information
noahfalk authored Oct 18, 2024
1 parent 24dd2bc commit c6e3eb7
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/coreclr/debug/ee/controller.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4413,6 +4413,9 @@ DebuggerPatchSkip::DebuggerPatchSkip(Thread *thread,
DebuggerControllerPatch *patch)
: DebuggerController(thread, AppDomain::GetCurrentDomain()),
m_address(patch->address)
#ifdef OUT_OF_PROCESS_SETTHREADCONTEXT
,m_fInPlaceSS(false)
#endif
{
LOG((LF_CORDB, LL_INFO10000,
"DPS::DPS: Patch skip 0x%p\n", patch->address));
Expand Down

0 comments on commit c6e3eb7

Please sign in to comment.