Skip to content

Commit

Permalink
Review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
BruceForstall committed Oct 13, 2023
1 parent 0410dd4 commit cf4e02b
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions src/coreclr/jit/importer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -11471,16 +11471,14 @@ void Compiler::impImportBlock(BasicBlock* block)
// This will re-import all the successors of block (as well as each of their predecessors)
impReimportSpillClique(block);

// For blocks that haven't been imported yet, we still need to mark them as pending import.
// Filter successor from BBJ_EHFILTERRET have already been handled, above.
if (!block->KindIs(BBJ_EHFILTERRET))
// We don't expect to see BBJ_EHFILTERRET here.
assert(!block->KindIs(BBJ_EHFILTERRET));

for (BasicBlock* const succ : block->Succs())
{
for (BasicBlock* const succ : block->Succs())
if ((succ->bbFlags & BBF_IMPORTED) == 0)
{
if ((succ->bbFlags & BBF_IMPORTED) == 0)
{
impImportBlockPending(succ);
}
impImportBlockPending(succ);
}
}
}
Expand All @@ -11489,7 +11487,8 @@ void Compiler::impImportBlock(BasicBlock* block)
// otherwise just import the successors of block

// Does this block jump to any other blocks?
// Filter successor from BBJ_EHFILTERRET have already been handled, above.
// Filter successor from BBJ_EHFILTERRET have already been handled above in the call
// to impVerifyEHBlock().
if (!block->KindIs(BBJ_EHFILTERRET))
{
for (BasicBlock* const succ : block->Succs())
Expand Down

0 comments on commit cf4e02b

Please sign in to comment.