Skip to content

Commit

Permalink
[wasm] WasmDebugLevel in samples (#79644)
Browse files Browse the repository at this point in the history
* do not enable debugging is samples in release mode because it disables interp optimizations
* feedback from @thaystg and @radical
  • Loading branch information
pavelsavara authored Dec 15, 2022
1 parent 53bcf1c commit e395c7c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/mono/sample/wasm/DefaultBrowserSample.targets
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
<WasmMainJSPath>main.js</WasmMainJSPath>
<DebugSymbols>true</DebugSymbols>
<DebugType>embedded</DebugType>
<WasmDebugLevel>1</WasmDebugLevel>
<!-- note that enabling debugger disables interp optimizations -->
<WasmDebugLevel Condition="'$(Configuration)' == 'Debug'">-1</WasmDebugLevel>
<GenerateRunScriptForSample Condition="'$(ArchiveTests)' == 'true'">true</GenerateRunScriptForSample>
<RunScriptCommand>$(ExecXHarnessCmd) wasm test-browser --app=. --browser=Chrome $(XHarnessBrowserPathArg) $(WasmXHarnessArgs) --html-file=index.html --output-directory=$(XHarnessOutput) -- $(MSBuildProjectName).dll</RunScriptCommand>
</PropertyGroup>
Expand Down

0 comments on commit e395c7c

Please sign in to comment.