-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix register resolution handling of RefTypeUpperVectorRestore (#92171)
After RefTypeUpperVectorRestore was handled, and an upper vector restore IR node was added, LSRA incorrectly kept processing the RefTypeUpperVectorRestore RefPosition. This led to incorrectly adding a GTF_SPILL flag to the associated LCL_VAR. This in turn led some LCL_VAR to be both last use and GTF_SPILL, which confused debug info processing: it tried to "close" a range twice when it only expects to see a "close" operation once. Fixes #91215
- Loading branch information
1 parent
f5cff04
commit ebe6f54
Showing
3 changed files
with
54 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
src/tests/JIT/Regression/JitBlue/Runtime_91215/Runtime_91215.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
// Found by Antigen | ||
|
||
using System; | ||
using System.Collections.Generic; | ||
using System.Runtime.CompilerServices; | ||
using System.Runtime.Intrinsics; | ||
using System.Runtime.Intrinsics.Arm; | ||
using System.Numerics; | ||
using Xunit; | ||
|
||
public class TestClass | ||
{ | ||
static ulong s_ulong_18 = 5; | ||
static Vector128<ulong> s_v128_ulong_36 = Vector128.Create((ulong)5, 0); | ||
Vector128<ulong> v128_ulong_87 = Vector128.CreateScalar((ulong)5); | ||
private void Method0() | ||
{ | ||
unchecked | ||
{ | ||
s_ulong_18 = Vector128.Dot(v128_ulong_87 += s_v128_ulong_36 *= v128_ulong_87| (s_v128_ulong_36 = v128_ulong_87), v128_ulong_87 = (s_v128_ulong_36 *= Vector128<ulong>.Zero)* (v128_ulong_87 *= s_v128_ulong_36)); | ||
return; | ||
} | ||
} | ||
|
||
[Fact] | ||
public static void TestEntryPoint() | ||
{ | ||
new TestClass().Method0(); | ||
} | ||
} | ||
/* | ||
Environment: | ||
set COMPlus_TieredCompilation=0 | ||
set COMPlus_JitStress=2 | ||
Assert failure(PID 6932 [0x00001b14], Thread: 5892 [0x1704]): Assertion failed '!m_VariableLiveRanges->back().m_EndEmitLocation.Valid()' in 'TestClass:Method0():this' during 'Generate code' (IL size 130; hash 0x46e9aa75; FullOpts) | ||
File: D:\a\_work\1\s\src\coreclr\jit\codegencommon.cpp Line: 8729 | ||
Image: e:\kpathak\CORE_ROOT\corerun.exe | ||
*/ |
8 changes: 8 additions & 0 deletions
8
src/tests/JIT/Regression/JitBlue/Runtime_91215/Runtime_91215.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
<PropertyGroup> | ||
<Optimize>True</Optimize> | ||
</PropertyGroup> | ||
<ItemGroup> | ||
<Compile Include="$(MSBuildProjectName).cs" /> | ||
</ItemGroup> | ||
</Project> |