Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] WBT tests which use SkiaSharp needs to be updated when they contain native libs built against newer emscripten #103566

Closed
radekdoulik opened this issue Jun 17, 2024 · 2 comments · Fixed by #109232
Closed

[wasm] WBT tests which use SkiaSharp needs to be updated when they contain native libs built against newer emscripten #103566

radekdoulik opened this issue Jun 17, 2024 · 2 comments · Fixed by #109232
Assignees
@radekdoulik
Labels
arch-wasm WebAssembly architecture area-Build-mono disabled-test The test is disabled in source code against the issue in-pr There is an active PR which will close this issue when it is merged os-browser Browser variant of arch-wasm
Milestone
Future

Comments

@radekdoulik
Copy link
Member

Currently SkiSharp is built against emscripten 3.1.34.

We will need emscripten 3.1.56 for WBT tests soon.
@radekdoulik radekdoulik added this to the Future milestone Jun 17, 2024
@radekdoulik radekdoulik self-assigned this Jun 17, 2024
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture disabled-test The test is disabled in source code against the issue os-browser Browser variant of arch-wasm labels Jul 4, 2024
@radekdoulik
Copy link
Member Author

mono/SkiaSharp#3010 is now using 3.1.56

we can try to use it once there are nuget packages published

@radekdoulik
Copy link
Member Author

@mattleibow I wonder whether you plan to do new release of SkiSharp soon? we are using your packages in our WBT (wasm build tests), so that would help us enable few of the tests.

@radekdoulik radekdoulik mentioned this issue Oct 25, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radekdoulik radekdoulik

Labels
arch-wasm WebAssembly architecture area-Build-mono disabled-test The test is disabled in source code against the issue in-pr There is an active PR which will close this issue when it is merged os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

[wasm] Re-enable skiasharp WBT tests radekdoulik/runtime
2 participants
@pavelsavara @radekdoulik