[wasm] Re-enable skiasharp WBT tests #109232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
radekdoulik
added
area-Infrastructure-mono
and removed
needs-area-label
That would trigger build error, because we don't support that combination anymore
Put NativeFileReference files after the runtime libs. This server as a workaround of dotnet#109289
This was referenced Oct 30, 2024
This was referenced Nov 1, 2024
radekdoulik
force-pushed
the
pr-enable-skiasharp-tests-again
branch
from
adbf98f
to
a7ab465
Compare
This was referenced Nov 19, 2024
Open
This reverts commit e320fd6.
This was referenced Nov 19, 2024
pavelsavara
approved these changes
Nov 19, 2024
akoeplinger
approved these changes
Nov 19, 2024
maraf
approved these changes
Nov 20, 2024
|
/ba-g the failures are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #103566
The included llvm bump (and emsdk, icu) fixes #109289 through dotnet/llvm-project#630