Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wasm][AOT] methods with try/catch/finally blocks are not AOTed #111281

Open
jeromelaban opened this issue Jan 10, 2025 · 1 comment · May be fixed by #111318
Open

[Wasm][AOT] methods with try/catch/finally blocks are not AOTed #111281

jeromelaban opened this issue Jan 10, 2025 · 1 comment · May be fixed by #111318
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono in-pr There is an active PR which will close this issue when it is merged os-browser Browser variant of arch-wasm
Milestone
10.0.0

Comments

@jeromelaban
Copy link
Contributor

jeromelaban commented Jan 10, 2025 •
edited
Loading

Description

Related to the work in #56309, the AOT compiler is skipping methods containing try/catch/finally blocks, specifically. try/finally and try/catch blocks are AOTed properly.

This causes those specific methods to be executed by the interpreter, therefore being slow.

Reproduction Steps

Build and run the following repro: 20250110-issue-111281-ehissue02.zip

The output looks as follows in the profiler:

Image

Where the last method should be be entering the interpreter to execute.

Expected behavior

No interpreter is used to execute any of the methods defined by the user when a try/catch/finally pattern is used.

Actual behavior

See above.

Regression?

No. Related to #78653.

Known Workarounds

Split the methods so that one contains a try/finally, and the other a try/catch, if possible.

Configuration

9.0.100

Other information

No response
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 10, 2025
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jan 10, 2025
@jeromelaban jeromelaban mentioned this issue Jan 10, 2025
Open
@steveisok steveisok added os-browser Browser variant of arch-wasm arch-wasm WebAssembly architecture labels Jan 10, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@steveisok steveisok added area-Codegen-AOT-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 10, 2025
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Jan 10, 2025
@lewing lewing added this to the 10.0.0 milestone Jan 10, 2025
@BrzVlad BrzVlad linked a pull request Jan 12, 2025 that will close this issue
Open
jeromelaban added a commit to unoplatform/uno that referenced this issue Jan 14, 2025
@jeromelaban
perf(wasm): Split methods containing try/catch/finally blocks
f6108bb 
Related to dotnet/runtime#111281
@jeromelaban jeromelaban mentioned this issue Jan 14, 2025
Merged
mergify bot pushed a commit to unoplatform/uno that referenced this issue Jan 15, 2025
@jeromelaban @mergify
perf(wasm): Split methods containing try/catch/finally blocks
c4df6bf 
Related to dotnet/runtime#111281

(cherry picked from commit f6108bb)
@mergify mergify bot mentioned this issue Jan 15, 2025
Merged
mergify bot pushed a commit to unoplatform/uno that referenced this issue Jan 15, 2025
@jeromelaban @mergify
perf(wasm): Split methods containing try/catch/finally blocks
89b8d67 
Related to dotnet/runtime#111281

(cherry picked from commit f6108bb)

# Conflicts:
#	src/Uno.UI/UI/Xaml/Controls/Frame/Frame.legacy.cs
@mergify mergify bot mentioned this issue Jan 15, 2025
Merged
jeromelaban added a commit to unoplatform/Uno.Wasm.Bootstrap that referenced this issue Jan 20, 2025
@jeromelaban
chore: Update runtime to include Wasm+AOT fix
1010b43 
dotnet/runtime#111281
@jeromelaban jeromelaban mentioned this issue Jan 20, 2025
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono in-pr There is an active PR which will close this issue when it is merged os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

[mono][wasm] AOT more methods containing EH clauses BrzVlad/runtime
3 participants
@lewing @steveisok @jeromelaban