Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser-wasm] Support Mono runtime components in workload #54565

Closed
lambdageek opened this issue Jun 22, 2021 · 5 comments
Closed

[browser-wasm] Support Mono runtime components in workload #54565

lambdageek opened this issue Jun 22, 2021 · 5 comments
Assignees
@radekdoulik
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono
Milestone
6.0.0

Comments

@lambdageek
Copy link
Member

The browser-wasm workload should support selecting different mono runtime components (#50862) for different configurations.

This depends on #54417
@dotnet-issue-labeler dotnet-issue-labeler bot added area-VM-meta-mono untriaged New issue has not been triaged by the area owner labels Jun 22, 2021
@ghost
Copy link

ghost commented Jun 22, 2021

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

The browser-wasm workload should support selecting different mono runtime components (#50862) for different configurations.

This depends on #54417

Author: lambdageek
Assignees: -
Labels:

area-VM-meta-mono, untriaged
Milestone: -

@lambdageek lambdageek mentioned this issue Jun 22, 2021
Closed
17 tasks
@lambdageek lambdageek added arch-wasm WebAssembly architecture and removed untriaged New issue has not been triaged by the area owner labels Jun 22, 2021
@lambdageek lambdageek added this to the 6.0.0 milestone Jun 22, 2021
@ghost
Copy link

ghost commented Jun 22, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

The browser-wasm workload should support selecting different mono runtime components (#50862) for different configurations.

This depends on #54417

Author: lambdageek
Assignees: -
Labels:

arch-wasm, area-VM-meta-mono
Milestone: -

@lambdageek lambdageek mentioned this issue Jun 22, 2021
Merged
lambdageek added a commit to lambdageek/runtime that referenced this issue Jun 22, 2021
@lambdageek
[wasm] Build static components; include hot_reload in runtime
be8a1e8 
Workaround until dotnet#54565 is fixed
Build the runtime always with support for hot_reload, and without diagnostics_tracing
@radical
Copy link
Member

radical commented Jun 23, 2021

From Wasm targets pov, they will get a list of files to link for dotnet.js/wasm?

github-actions bot pushed a commit that referenced this issue Jun 23, 2021
@lambdageek
[wasm] Build static components; include hot_reload in runtime
20e5245 
Workaround until #54565 is fixed
Build the runtime always with support for hot_reload, and without diagnostics_tracing
@lambdageek
Copy link
Member Author

lambdageek commented Jun 23, 2021 •
edited
Loading

From Wasm targets pov, they will get a list of files to link for dotnet.js/wasm?

The workflow will be the same for all workloads:

  1. Populate @(_MonoComponents) with the components you want for example "" or "hot_reload;diagnostics_tracing" or "hot_reload" etc
  2. Call the _MonoSelectRuntimeComponents target at the appropriate time in your build
  3. Combine @(_MonoRuntimeComponentLink) with the full path of the native/ directory of your runtime pack and link those libraries together with libmonosgen-2.0.a when building your host.
  4. You now have an app bundle with components (or component stubs, depending on what you chose)

lambdageek added a commit that referenced this issue Jun 24, 2021
@lambdageek @thaystg
[wasm] Build static components; include hot_reload in runtime (#54568)
93f407d 
* [wasm] Build static components; include hot_reload in runtime

   Workaround until #54565 is fixed
   Build the runtime always with support for hot_reload, and without diagnostics_tracing

* Update wasm.proj

* Add a browser functional test for hot reload

   Just check that the capabilities are non-empty which is a good proxy for hot reload being enabled in the runtime.

* Turn off trimming for hot reload functional test

* Disable test on browser AOT

* fix whitespace

Co-authored-by: Thays Grazia <[email protected]>
steveisok pushed a commit that referenced this issue Jun 24, 2021
@github-actions @lambdageek @thaystg
[release/6.0-preview6] [wasm] Build static components; include hot_re…
12c92e8 
…load in runtime (#54622)

Backport of #54568 to release/6.0-preview6

Workaround until #54565 is fixed
Build the runtime always with support for hot_reload, and without diagnostics_tracing

Co-authored-by: Aleksey Kliger <[email protected]>
Co-authored-by: Thays Grazia <[email protected]>
@lewing lewing assigned radical and radekdoulik and unassigned radical Jul 14, 2021
@lewing lewing mentioned this issue Jul 14, 2021
Closed
@lewing
Copy link
Member

lewing commented Jul 14, 2021

now is that #54432 is in we need to follow up here

@radekdoulik radekdoulik mentioned this issue Jul 14, 2021
Merged
@lewing lewing closed this as completed Jul 16, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@radekdoulik radekdoulik

Labels
arch-wasm WebAssembly architecture area-VM-meta-mono
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
4 participants
@radical @lewing @lambdageek @radekdoulik