-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simpleruntimeeventvalidation test failing in CI #88499
Comments
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBuild InformationBuild: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=331166 Error MessageFill the error message using step by step known issues guidance. {
"ErrorMessage": "",
"ErrorPattern": "tracing.eventpipe.simpleruntimeeventvalidation.simpleruntimeeventvalidation.simpleruntimeeventvalidation",
"BuildRetry": false,
"ExcludeConsoleLog": false
} Known issue validationBuild: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=331166 Report
Summary
|
Looks like the test fails for non-wasm cases with a real error:
I'll open a new PR to disable this. |
Issue: dotnet#88499 Failing with: ``` Expected: True Actual: False Stack Trace: at tracing_eventpipe._simpleruntimeeventvalidation_simpleruntimeeventvalidation_simpleruntimeeventvalidation_._simpleruntimeeventvalidation_simpleruntimeeventvalidation_simpleruntimeeventvalidation_sh() at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor) at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr) Output: Return code: 1 Raw output file: /root/helix/work/workitem/uploads/Reports/tracing.eventpipe/simpleruntimeeventvalidation/simpleruntimeeventvalidation/simpleruntimeeventvalidation.output.txt Raw output: BEGIN EXECUTION /root/helix/work/correlation/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true simpleruntimeeventvalidation.dll '' 0.0s: ==TEST STARTING== 0.2s: Connecting to EventPipe... 0.2s: Started sending sentinel events... 0.4s: Creating EventPipeEventSource... 0.4s: EventPipeEventSource created 0.4s: Dynamic.All callback registered 0.4s: Running optional trace validator 0.4s: Finished running optional trace validator 0.4s: Starting stream processing... 0.6s: Saw sentinel event 0.6s: Stopped sending sentinel events 0.6s: Starting event generating action... 0.6s: Called GC.Collect() 0 times... 0.7s: Called GC.Collect() 10 times... 0.7s: Called GC.Collect() 20 times... 0.7s: Called GC.Collect() 30 times... 0.7s: Called GC.Collect() 40 times... 0.7s: Stopping event generating action 0.7s: Sending StopTracing command... 0.7s: Saw new provider 'Microsoft-DotNETCore-EventPipe' 0.7s: Stopping stream processing 0.7s: Dropped 0 events 0.7s: Finished StopTracing command 0.7s: Reader task finished 0.8s: Test FAILED! 0.8s: No events for provider "Microsoft-Windows-DotNETRuntime" 0.8s: Configuration: 0.8s: { 0.8s: providers: [ 0.8s: ] 0.8s: } 0.8s: Expected: 0.8s: { 0.8s: "Microsoft-Windows-DotNETRuntime" = -1 +- -0 0.8s: } 0.8s: Actual: 0.8s: { 0.8s: "Microsoft-DotNETCore-EventPipe" = 1 0.8s: } 0.8s: ==TEST FINISHED: FAILED!== Expected: 100 Actual: 255 END EXECUTION - FAILED Test failed. Trying to see if dump file was created in /home/helixbot/dotnetbuild/dumps since 7/6/2023 11:55:21 PM Test Harness Exitcode is : 1 To run the test: > set CORE_ROOT=/root/helix/work/correlation > /root/helix/work/workitem/e/tracing/eventpipe/simpleruntimeeventvalidation/simpleruntimeeventvalidation/simpleruntimeeventvalidation.sh ```
Keeping this issue open as the corresponding test is being disabled in #88500, but still needs to be fixed. I will remove the |
* Disable `simpleruntimeeventvalidation` test on mono. Issue: #88499 Failing with: ``` Expected: True Actual: False Stack Trace: at tracing_eventpipe._simpleruntimeeventvalidation_simpleruntimeeventvalidation_simpleruntimeeventvalidation_._simpleruntimeeventvalidation_simpleruntimeeventvalidation_simpleruntimeeventvalidation_sh() at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor) at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr) Output: Return code: 1 Raw output file: /root/helix/work/workitem/uploads/Reports/tracing.eventpipe/simpleruntimeeventvalidation/simpleruntimeeventvalidation/simpleruntimeeventvalidation.output.txt Raw output: BEGIN EXECUTION /root/helix/work/correlation/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true simpleruntimeeventvalidation.dll '' 0.0s: ==TEST STARTING== 0.2s: Connecting to EventPipe... 0.2s: Started sending sentinel events... 0.4s: Creating EventPipeEventSource... 0.4s: EventPipeEventSource created 0.4s: Dynamic.All callback registered 0.4s: Running optional trace validator 0.4s: Finished running optional trace validator 0.4s: Starting stream processing... 0.6s: Saw sentinel event 0.6s: Stopped sending sentinel events 0.6s: Starting event generating action... 0.6s: Called GC.Collect() 0 times... 0.7s: Called GC.Collect() 10 times... 0.7s: Called GC.Collect() 20 times... 0.7s: Called GC.Collect() 30 times... 0.7s: Called GC.Collect() 40 times... 0.7s: Stopping event generating action 0.7s: Sending StopTracing command... 0.7s: Saw new provider 'Microsoft-DotNETCore-EventPipe' 0.7s: Stopping stream processing 0.7s: Dropped 0 events 0.7s: Finished StopTracing command 0.7s: Reader task finished 0.8s: Test FAILED! 0.8s: No events for provider "Microsoft-Windows-DotNETRuntime" 0.8s: Configuration: 0.8s: { 0.8s: providers: [ 0.8s: ] 0.8s: } 0.8s: Expected: 0.8s: { 0.8s: "Microsoft-Windows-DotNETRuntime" = -1 +- -0 0.8s: } 0.8s: Actual: 0.8s: { 0.8s: "Microsoft-DotNETCore-EventPipe" = 1 0.8s: } 0.8s: ==TEST FINISHED: FAILED!== Expected: 100 Actual: 255 END EXECUTION - FAILED Test failed. Trying to see if dump file was created in /home/helixbot/dotnetbuild/dumps since 7/6/2023 11:55:21 PM Test Harness Exitcode is : 1 To run the test: > set CORE_ROOT=/root/helix/work/correlation > /root/helix/work/workitem/e/tracing/eventpipe/simpleruntimeeventvalidation/simpleruntimeeventvalidation/simpleruntimeeventvalidation.sh ``` * Fix test name
cc @lambdageek |
@lateralusX #88499 (comment) pretty sure this is expected right? we use EventPipe, not ETW. The tests needs to be updated? |
Looks like this test, src/tests/tracing/eventpipe/simpleruntimeeventvalidation/simpleruntimeeventvalidation.cs depends on CoreCLR specific GC events that we currently won't emit on Mono, so this new EventPipe test needs to be disabled on Mono or test needs to use other events emitted by Mono's implementation of Microsoft-Windows-DotNETRuntime. Simple fix is to disable the test on mono like already done in #88500. |
The pattern in the issue is causing false positives on PRs, so I will remove the |
This test should not run on Mono runtime as @lateralusX mentioned above, and the linked issue is resolved. Closing this issue. |
Build Information
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=331166
Build error leg or test failing: tracing\eventpipe\simpleruntimeeventvalidation\simpleruntimeeventvalidation\simpleruntimeeventvalidation.cmd
Pull request: #87562
Error Message
Fill the error message using step by step known issues guidance.
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=331166
Error message validated:
tracing.eventpipe.simpleruntimeeventvalidation.simpleruntimeeventvalidation.simpleruntimeeventvalidation
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 7/6/2023 11:55:11 PM UTC
Report
Summary
The text was updated successfully, but these errors were encountered: