-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[S390x] Fix stack offset size while passing structure as argument. #101103
Conversation
Tagging subscribers to this area: @lambdageek, @steveisok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. @lambdageek, does it look good to you?
@steveisok can we run the runtime-community CI ? |
/azp run runtime-community |
Azure Pipelines successfully started running 1 pipeline(s). |
There are no failures reported in s390x CI and other failures are unrelated. is this good to merge? |
/azp run runtime-community |
Azure Pipelines successfully started running 1 pipeline(s). |
re-running one more time. there was a hung CI job, and we can't merge on red anymore. |
when passing the arguments structure by reference we allocate extra un-necessary bytes in the stack (As it should only use 8 bytes for the reference address).
this example depicts when passing a structure of 16 bytes as an argument
before the patch:
after the patch: