Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[S390x] Fix stack offset size while passing structure as argument. #101103

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

saitama951
Copy link
Contributor

@saitama951 saitama951 commented Apr 16, 2024

when passing the arguments structure by reference we allocate extra un-necessary bytes in the stack (As it should only use 8 bytes for the reference address).

this example depicts when passing a structure of 16 bytes as an argument
before the patch:

18: e3 20 f0 a0 00 24 stg %r2,160(%r15)
1e: e3 30 f0 b0 00 24 stg %r3,176(%r15)

after the patch:

18: e3 20 f0 a0 00 24 stg %r2,160(%r15)
1e: e3 30 f0 a8 00 24 stg %r3,168(%r15)

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 16, 2024
Copy link
Contributor

Tagging subscribers to this area: @lambdageek, @steveisok
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@steveisok steveisok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. @lambdageek, does it look good to you?

@saitama951
Copy link
Contributor Author

@steveisok can we run the runtime-community CI ?

@lambdageek
Copy link
Member

/azp run runtime-community

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@saitama951
Copy link
Contributor Author

There are no failures reported in s390x CI and other failures are unrelated. is this good to merge?

@lambdageek
Copy link
Member

/azp run runtime-community

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek
Copy link
Member

re-running one more time. there was a hung CI job, and we can't merge on red anymore.

michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Codegen-JIT-mono community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants