Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for dataflow with invalid annotations #101214

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Apr 17, 2024

Adds some test coverage for #101211, including a case where ILLink/NativeAot have a similar issue.

@sbomer sbomer requested a review from jtschuster April 17, 2024 22:05
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 17, 2024
@sbomer sbomer added area-Tools-ILLink .NET linker development as well as trimming analyzers and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 17, 2024
@@ -147,6 +147,12 @@ public Task UnusedComInterfaceIsKept ()
return RunTest (allowMissingWarnings: true);
}

[Fact]
public Task UnusedComInterfaceIsRemoved ()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just updating the generated test sources to include the new test added in #101087.

@sbomer sbomer merged commit 3b1836c into dotnet:main Apr 18, 2024
116 checks passed
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
Adds some test coverage for
dotnet#101211, including a case
where ILLink/NativeAot have a similar issue.
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants