[mono] UnsafeAccessor: Enable tests for extern static methods without type parameters #101265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
|
Tagging subscribers to this area: @steveisok, @lambdageek |
fanyang-mono
added
area-VM-meta-mono
and removed
needs-area-label
6 tasks
fanyang-mono
commented
Apr 18, 2024
This was referenced Apr 19, 2024
This was referenced Apr 19, 2024
|
All CI failures are known. |
lambdageek
reviewed
Apr 22, 2024
| @@ -2322,7 +2322,7 @@ method_sig_from_accessor_sig (MonoMethodBuilder *mb, gboolean hasthis, MonoMetho | |||
| ret->hasthis = hasthis; | |||
| for (int i = 1; i < ret->param_count; i++) | |||
| ret->params [i - 1] = ret->params [i]; | |||
| memset (&ret->params[ret->param_count - 1], 0, sizeof (MonoType)); // just in case | |||
| memset (&ret->params[ret->param_count - 1], 0, sizeof (MonoType*)); // just in case | |||
There was a problem hiding this comment.
Let's keep this in mind if we need to do a net8.0 backport of any unsafe accessor fixes.
lambdageek
approved these changes
Apr 22, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
… type parameters (dotnet#101265) * Enable tests for methods without type parameters * Enable more field tests * Enable all field tests * Fix the type to get size for
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #99830