Ignore line endings when comparing AsnXml generated content #101657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
am11
reviewed
Apr 28, 2024
src/libraries/Common/src/System/Security/Cryptography/Asn1/AsnXml.targets
Outdated
Show resolved
Hide resolved
am11
reviewed
Apr 28, 2024
src/libraries/Common/src/System/Security/Cryptography/Asn1/AsnXml.targets
Outdated
Show resolved
Hide resolved
This was referenced Apr 28, 2024
am11
reviewed
Apr 28, 2024
src/libraries/Common/src/System/Security/Cryptography/Asn1/AsnXml.targets
Show resolved
Hide resolved
bartonjs
approved these changes
Apr 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some developers configure their git to check out files as LF instead of CRLF on Windows. That causes the diff detection for the AsnXml target to think the generator produced a meaningful change, when it really didn't. There unfortunately is not a good way to fix this in
.gitattributesif the developer really insists that the line endings are LF on Windows, e.g:We can't tell .gitattributes "No really, you definitely want to check these files out as CRLF on Windows and LF everywhere else".
Instead, we can just ignore the line endings for comparison sake. I could not figure out a way to do this in MSBuild, so I added a small C# task. I feel like this should be doable with
<ReadLinesFromFile />and comparing theLinesoutput, but I couldn't quite get that to work.Fixes #101651