[wasm] Switch off HybridGlobalization lane on v8 on CI
#101671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
mkhamoyan
approved these changes
Apr 29, 2024
maraf
approved these changes
Apr 29, 2024
This was referenced Apr 29, 2024
maraf
reviewed
Apr 29, 2024
...untime/tests/System.Globalization.Tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
Show resolved
Hide resolved
This reverts commit 38f64f7.
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
* Stop testing on v8. * Try to block by scenario, * Limit scenarios. This reverts commit 38f64f7.
|
backport to release/8.0 |
|
/azp backport to release/8.0 |
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/9155347363 |
|
@ilonatommy backporting to release/8.0-staging failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Stop testing on v8.
Using index info to reconstruct a base tree...
M eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
CONFLICT (content): Merge conflict in eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Stop testing on v8.
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@ilonatommy an error occurred while backporting to release/8.0-staging, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
* Stop testing on v8. * Try to block by scenario, * Limit scenarios. This reverts commit 38f64f7.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101634.
This PR removes
HybridGlobalizationtests on v8.Reasoning:
Maintaining
HybridGlobalizationtests takes considerable effort - the API response might change with each host version and it does not mean that they are incorrect. As the result, with each version change we have to update expected test results.HybridGlobalizationis primarily targeting browser and node. While updating the tests for browser and node makes sense - to catch any changes that are indeed invalid - updating it for v8 is a not necessary effort.