-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][aot] Do not overwrite scenarios
argument if they were passed
#103229
[CI][aot] Do not overwrite scenarios
argument if they were passed
#103229
Conversation
/azp run runtime-wasm |
Azure Pipelines failed to run 1 pipeline(s). |
Tagging subscribers to this area: @dotnet/area-system-globalization |
/azp run runtime-wasm |
Azure Pipelines failed to run 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines failed to run 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines failed to run 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines failed to run 1 pipeline(s). |
@akoeplinger, most probably I have an indent/syntax problem that I cannot spot, could you please take a look? |
@ilonatommy it looks like some issue with the |
/azp run runtime-wasm |
Azure Pipelines failed to run 1 pipeline(s). |
Thank you, I did not look there 🤦 |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
is #51746, so we cannot enable running them yet, I will have to block |
Continuation of switching off HybridGlobalization tests on v8.
HybridGlobalization_AOT
lane on CI was still running V8 because it was overwriting thescenarios
argument passed here:runtime/eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
Line 216 in e6c2e53
Example of run with v8 on:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=702059&view=logs&j=2c5d15bf-ca52-57a8-9a4e-bb898fb954b8
Now we don't overwrite if
scenarios
is already defined.