Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EOL versions (8.0-staging) #103393

Merged

Conversation

richlander
Copy link
Member

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 13, 2024
@build-analysis build-analysis bot mentioned this pull request Jun 13, 2024
@carlossanlop carlossanlop added Servicing-approved Approved for servicing release area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 3, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @richlander If this is ready to merge, please do the honors and smash that squash button.

@richlander
Copy link
Member Author

I have been waiting on a slow dev (me) to get new images created at build-prereqs. I have one last one left and then I can get back to these. I haven't forgotten about this and the other PR. I didn't realize when I started this that it would take so long. Good realization for next time.

@richlander
Copy link
Member Author

richlander commented Jul 7, 2024

Looks like libraries tests failing on Windows 10. Known issue: #104390.

    System.Net.Http.WinHttpHandlerFunctional.Tests.BidirectionStreamingTest.BackwardsCompatibility_DowngradeToHttp11 [FAIL]
      Assert.Throws() Failure
      Expected: typeof(System.Exception)
      Actual:   (No exception was thrown)
      Stack Trace:
        /_/src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/BidirectionStreamingTest.cs(345,0): at System.Net.Http.WinHttpHandlerFunctional.Tests.BidirectionStreamingTest.BackwardsCompatibility_DowngradeToHttp11()
        --- End of stack trace from previous location ---

@wfurt

@richlander richlander merged commit 6409793 into dotnet:release/8.0-staging Jul 16, 2024
137 checks passed
@richlander richlander deleted the update-eol-versions- branch July 16, 2024 17:15
@danmoseley
Copy link
Member

Do we need changes in any other repos?

@richlander
Copy link
Member Author

Great q. Yes. I have been making changes across a variety of repos. Sadly, I keep on finding more images to remediate. It would be excellent if others want to help.

Examples: https://github.com/dotnet/aspnetcore/pulls?q=is%3Apr+author%3Arichlander+is%3Aclosed

@@ -171,7 +171,7 @@ jobs:

# WASI
- ${{ if eq(parameters.platform, 'wasi_wasm') }}:
- (Ubuntu.2004.Amd64)[email protected]/dotnet-buildtools/prereqs:ubuntu-20.04-helix-wasm-amd64
- (Ubuntu.1804.Amd64)[email protected]/dotnet-buildtools/prereqs:ubuntu-18.04-helix-wasm-amd64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't look correct to me, it's downgrading the version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants