-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EOL versions (8.0-staging) #103393
Update EOL versions (8.0-staging) #103393
Conversation
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @richlander If this is ready to merge, please do the honors and smash that squash button.
I have been waiting on a slow dev (me) to get new images created at build-prereqs. I have one last one left and then I can get back to these. I haven't forgotten about this and the other PR. I didn't realize when I started this that it would take so long. Good realization for next time. |
Looks like libraries tests failing on Windows 10. Known issue: #104390. System.Net.Http.WinHttpHandlerFunctional.Tests.BidirectionStreamingTest.BackwardsCompatibility_DowngradeToHttp11 [FAIL]
Assert.Throws() Failure
Expected: typeof(System.Exception)
Actual: (No exception was thrown)
Stack Trace:
/_/src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/BidirectionStreamingTest.cs(345,0): at System.Net.Http.WinHttpHandlerFunctional.Tests.BidirectionStreamingTest.BackwardsCompatibility_DowngradeToHttp11()
--- End of stack trace from previous location --- |
Do we need changes in any other repos? |
Great q. Yes. I have been making changes across a variety of repos. Sadly, I keep on finding more images to remediate. It would be excellent if others want to help. Examples: https://github.com/dotnet/aspnetcore/pulls?q=is%3Apr+author%3Arichlander+is%3Aclosed |
@@ -171,7 +171,7 @@ jobs: | |||
|
|||
# WASI | |||
- ${{ if eq(parameters.platform, 'wasi_wasm') }}: | |||
- (Ubuntu.2004.Amd64)[email protected]/dotnet-buildtools/prereqs:ubuntu-20.04-helix-wasm-amd64 | |||
- (Ubuntu.1804.Amd64)[email protected]/dotnet-buildtools/prereqs:ubuntu-18.04-helix-wasm-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't look correct to me, it's downgrading the version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.