Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix return type marshalling on IsKeyStorePrivateKeyEntry #103825

Merged

Conversation

simonrozsival
Copy link
Member

This PR addresses #103337 (comment): the C code returns int32_t and the managed side specified wrong type.

/cc @akoeplinger @vcsjones

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@simonrozsival
Copy link
Member Author

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger
Copy link
Member

akoeplinger commented Jun 21, 2024

@vcsjones
Copy link
Member

vcsjones commented Jun 21, 2024

@akoeplinger

Should we fix the rest of the cases that use UnmanagedType.U1?

Those are existing p/invokes, and they "work" given that the C-bool we are using happen to be 1-byte.

This is a clear mismatch though. I think we should backport this PR to release/9.0-preview6. So perhaps it would make sense to keep this PR focused to make the backport to the release branch as easy as possible, and the others can be cleaned up in a separate PR.

@simonrozsival
Copy link
Member Author

The failing runtime-extra-platforms tests are unrelated

@simonrozsival simonrozsival merged commit ec996f9 into dotnet:main Jun 21, 2024
116 of 122 checks passed
@simonrozsival simonrozsival deleted the android-fix-x509-bool-marshalling branch June 21, 2024 19:55
@simonrozsival simonrozsival restored the android-fix-x509-bool-marshalling branch June 21, 2024 19:55
rzikm pushed a commit to rzikm/dotnet-runtime that referenced this pull request Jun 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants