-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] use also SslCertificateTrust when constructing CertificateContext #104541
[release/8.0-staging] use also SslCertificateTrust when constructing CertificateContext #104541
Conversation
…tnet#103372) * use also SslCertificateTrust when constructing CertificateContext * 'build * feedback
…ception (dotnet#104016) * Check if certificate collections are not empty before changing trust mode to custom root trust * Enable SslStream_ClientCertificateContext_SendsChain test on Android * Apply suggestions from reviews * Avoid unnecessary allocations
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
Friendly reminder that Monday July 15th is Code Complete day, that's the deadline to get this included in the August Release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
ce2fdb4
into
dotnet:release/8.0-staging
Backport of #103372 and #104016 to release/8.0-staging
Customer Impact
Customers developing Android apps are currently unable to use mutual TLS authentication in certain cases as the
SslStreamCertificateContext.Create(...)
method will fail to build an X509Chain instance if the certificate isn't trusted by the OS due to the limitations of the Android platform.Regression
Testing
Unit tests and manual testing on Android emulator.
Risk
Low. The change is mostly limited to Android where this API doesn't currently work in many cases.
/cc @vitek-karas @wfurt