Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solution files to include all CoreLib dependencies #104561

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Jul 8, 2024

VS requires all dependencies to be listed in a solution file. If they aren't present, they don't get built which usually fails the build then.

Update the three CoreLib solution files:

  • coreclr
  • mono
  • nativeaot

I forgot to mention that this fixes CoreLib failing to build in VS from a fresh clone. cc @EgorBo

VS requires all dependencies to be listed in a solution
file. If they aren't present, they don't get built which
usually fails the build then.

Update the three CoreLib solution files:
- coreclr
- mono
- nativeaot
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@huoyaoyuan
Copy link
Member

Does this cover the problem in #103819?

@ViktorHofer
Copy link
Member Author

Yes it does :) Forgot about commenting in your PR, sorry.

Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which usually fails the build then.

It only fails the build because there's a disagreement between where the build output should be between VS build and build.cmd build.

I always just copy a build.cmd-built binary to whatever location VS complains about.

It is unfortunate we need to add extra projects to the solution file that then slows down VS, but I know it is the current status quo.

LGTM.

@ViktorHofer
Copy link
Member Author

It is unfortunate we need to add extra projects to the solution file that then slows down VS, but I know it is the current status quo.

This mimics what dotnet build does with the difference that VS has an improved up-to-date check (fast up-to-date check) and doesn't even attempt to build projects in a solution that don't need to be built. 10 more projects shouldn't slow down VS. It's super fast in evaluating and restoring projects. If there's a difference then that probably has to do with us doing something wrong. I.e. I noticed that the fast up-to-date check doesn't work well under src/coreclr, which needs to be investigated and fixed.

It only fails the build because there's a disagreement between where the build output should be between VS build and build.cmd build.

That should be fixed, shouldn't it?

@ViktorHofer ViktorHofer merged commit ce92511 into main Jul 9, 2024
137 of 140 checks passed
@ViktorHofer ViktorHofer deleted the UpdateSlnsForCoreLib branch July 9, 2024 12:39
@MichalStrehovsky
Copy link
Member

MichalStrehovsky commented Jul 9, 2024

That should be fixed, shouldn't it?

I looked at it in the past and had no clue how to approach the VS build (how do I even get a binlog of the fast up-to-date check and why is it looking where it's looking)

(Also VS being super fast at anything doesn't really match my experience)

@ViktorHofer
Copy link
Member Author

You can set these two environment variables and then launch devenv.exe and will find binlogs produced under MSBUILDDEBUGPATH: https://learn.microsoft.com/en-us/visualstudio/ide/msbuild-logs?view=vs-2022#capture-binary-logs-through-visual-studio

matouskozak added a commit to matouskozak/runtime that referenced this pull request Jul 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants