-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update solution files to include all CoreLib dependencies #104561
Conversation
VS requires all dependencies to be listed in a solution file. If they aren't present, they don't get built which usually fails the build then. Update the three CoreLib solution files: - coreclr - mono - nativeaot
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Does this cover the problem in #103819? |
Yes it does :) Forgot about commenting in your PR, sorry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which usually fails the build then.
It only fails the build because there's a disagreement between where the build output should be between VS build and build.cmd build.
I always just copy a build.cmd-built binary to whatever location VS complains about.
It is unfortunate we need to add extra projects to the solution file that then slows down VS, but I know it is the current status quo.
LGTM.
This mimics what
That should be fixed, shouldn't it? |
I looked at it in the past and had no clue how to approach the VS build (how do I even get a binlog of the fast up-to-date check and why is it looking where it's looking) (Also VS being super fast at anything doesn't really match my experience) |
You can set these two environment variables and then launch devenv.exe and will find binlogs produced under |
…tnet#104561)" This reverts commit ce92511.
VS requires all dependencies to be listed in a solution file. If they aren't present, they don't get built which usually fails the build then.
Update the three CoreLib solution files:
I forgot to mention that this fixes CoreLib failing to build in VS from a fresh clone. cc @EgorBo