Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versioning to .NET 10 #106421

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

carlossanlop
Copy link
Member

Here's what we did last year: https://github.com/dotnet/runtime/pull/90558/files?diff=unified&w=1

We will need to make Version.Details.xml changes after emsdk and arcade update their darc versions.

IMPORTANT!

Do not merge until after the RC1 snap.

eng/Versions.props Outdated Show resolved Hide resolved
eng/Versions.props Show resolved Hide resolved
eng/Versions.props Outdated Show resolved Hide resolved
eng/testing/workloads-testing.targets Outdated Show resolved Hide resolved
Directory.Build.targets Outdated Show resolved Hide resolved
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@carlossanlop
Copy link
Member Author

@ViktorHofer opened another PR with the same purpose as this one. I'll let him take over this work: #106599

@ViktorHofer
Copy link
Member

ViktorHofer commented Aug 19, 2024

@carlossanlop re-targeting takes much longer. Please proceed with this branding PR. That's why #105343 mentions that this needs to be done in two separate phases.

@ViktorHofer ViktorHofer reopened this Aug 19, 2024
@carlossanlop
Copy link
Member Author

@carlossanlop re-targeting takes much longer. Please proceed with this branding PR. That's why #105343 mentions that this needs to be done in two separate phases.

@ViktorHofer so just the branding changes and notbing else?

@ViktorHofer
Copy link
Member

Yes, just the minimal changes that are required to change branding to .NET 10.

@carlossanlop
Copy link
Member Author

@ViktorHofer done. Can you please review again?

@carlossanlop
Copy link
Member Author

Test failure is known and pre-existing: #106865

@ViktorHofer @ericstj @akoeplinger @jkoritzinsky can I please get a review? I think these should be the minimal changes for branding.

@carlossanlop carlossanlop merged commit fc756e6 into dotnet:main Aug 23, 2024
152 of 157 checks passed
@carlossanlop carlossanlop deleted the BumpVersioningTo10 branch August 23, 2024 18:51
@agocke
Copy link
Member

agocke commented Aug 23, 2024

Wait -- last year we hit a lot of problems because runtime went before SDK. I thought we were going to do SDK first this time.

@carlossanlop
Copy link
Member Author

Oops, already merged.

@agocke according to #105343 (comment) , branding is done first.

But let's monitor de official builds and deps flows. Hopefully we dont break the world.

@ViktorHofer
Copy link
Member

ViktorHofer commented Aug 23, 2024

@agocke branding needs to always happen independently of other repos. Runtime can't wait on sdk for that. I think you are talking about re-targeting which this PR doesn't do.

And even for re-targeting we don't want to wait for SDK as in this release we aren't dropping any TFMs (net8.0, net9.0 => net8.0, net9.0, net10.0). I don't see a reason why we should wait for SDK to re-target first. Would you mind elaborating?

@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants