[release/9.0-rc1] JIT: update simd base type when combining simd nodes for bitwise ops #106520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #106510 to release/9.0-rc1
/cc @AndyAyersMS
Customer Impact
Found by Antigen (internal exploratory test generator).
Certain patterns of Vector512 usage will lead to unexpected failures like
Regression
Looks like this was introduced recently, by #104517.
Testing
While we generally have good coverage for HW intrinsics used in isolation, the combinatorics for HW intrinsics are unfavorable (thousands of intrinsics --> millions of pairs, billions of triples, etc). Antigen and similar tools attempt to explore the space of composition to a certain degree.
The fix was validated on the Antigen test case, and that case is now included in our regression suite.
Risk
Low. Only impacts a specific pattern of intrinsics when running on AVX-512 capable hardware.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging
, notrelease/X.0
.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.