Relax PNSE expectation for OSSL providers on Apple platforms #106804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 22, 2024
bartonjs
approved these changes
Aug 22, 2024
krwq
added a commit
that referenced
this pull request
Aug 23, 2024
Merged
4 tasks
artl93
pushed a commit
that referenced
this pull request
Aug 23, 2024
…n OSSL less than 3.0 (#106753) * Make SafeEvpPKeyHandle.OpenKeyFromProvider throw PNSE on OSSL less than 3.0 * address feedback * Address recent feedback * Relax PNSE expectation for OSSL providers on Apple platforms (#106804) --------- Co-authored-by: Krzysztof Wicher <[email protected]> Co-authored-by: Krzysztof Wicher <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #106794
(or at least should as I don't have OSX to repro this specific issue)
This is relaxing expectations on when PNSE should happen - specifically on Apple platforms we will also allow - I suspect some OSX-es on our CI have OpenSSL installed but our test PlatformDetection might not detect that correctly (currently
IsOpenSsl3is always false for any Apple platform). Product does the feature detection by checking API presence and therefore discrepancy is possible.