Fix storage of stack trace of exception from reflection #106901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was one more case where we have saved the stack trace into the _remoteStackTraceString field in the exception when the exception was passing from reflection invoked code to the caller of that code. While there is no visible difference in the Exception.ToString, a SOS test was failing due to that. And it is not necessary to save the stack trace there. I have thought about the cases when we really need the stack trace saved into the _remoteStackTraceString and I believe that actually the only case is when an existing exception is thrown again in managed code. So I have removed the option to save the stack trace from all the variants of the DispatchManagedException.
|
cc: @mikem8361 |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mikem8361
approved these changes
Aug 23, 2024
jkotas
reviewed
Aug 23, 2024
| if (preserveStackTrace) | ||
| { | ||
| pThread->IncPreventAbort(); | ||
| ExceptionPreserveStackTrace(throwable); |
There was a problem hiding this comment.
I am wondering whether the one remaining use of ExceptionPreserveStackTrace in the VM is actually necessary. It is wrapped in very confusing logic that does not look right and we seem to be getting lucky that it never kicks in practice.
It is fine to clean it up in a separate PR.
There was a problem hiding this comment.
Thank you, I'll look into it separately.
jkotas
approved these changes
Aug 23, 2024
This was referenced Aug 24, 2024
Open
3 tasks
|
/ba-g the changes are in coreclr, the legs that are failing (timing out) are NativeAOT builds only. |
|
Are we going to backport this to 9.0? |
|
@mikem8361 yes, I am planning to do that. |
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10600017871 |
4 tasks
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
There was one more case where we have saved the stack trace into the _remoteStackTraceString field in the exception when the exception was passing from reflection invoked code to the caller of that code. While there is no visible difference in the Exception.ToString, a SOS test was failing due to that. And it is not necessary to save the stack trace there. I have thought about the cases when we really need the stack trace saved into the _remoteStackTraceString and I believe that actually the only case is when an existing exception is thrown again in managed code. So I have removed the option to save the stack trace from all the variants of the DispatchManagedException.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was one more case where we have saved the stack trace into the
_remoteStackTraceStringfield in the exception when the exception was passing from reflection invoked code to the caller of that code. While there is no visible difference in theException.ToString, a SOS test was failing due to that. And it is not necessary to save the stack trace there.I have thought about the cases when we really need the stack trace saved into the
_remoteStackTraceStringand I believe that actually the only case is when an existing exception is thrown again in managed code. So I have removed the option to save the stack trace from all the variants of theDispatchManagedException.