Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MemoryStream_SeekOverflow_Throws on Linux #107163

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented Aug 29, 2024

Disabling test to see if it relieves CI.
See #100558 (comment).

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

@jozkee jozkee changed the title Disable MemoryStream_SeekOverflow_Throws Disable MemoryStream_SeekOverflow_Throws on Linux Aug 29, 2024
Comment on lines 106 to +107
[ActiveIssue("https://github.com/dotnet/runtime/issues/100225", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.IsX64Process))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/100558", TestPlatforms.Linux)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want to have more than one ActiveIssue.

The previous ActiveIssue deactivated the test in mono, windows, x64.

The current ActiveIssue is deactivating the test in all runtimes, in all architectures, but only in Linux. Isn't it also affecting Windows coreclr?

I think we should deactivate this test for everything. No platform filters. That way we can be 100% sure if the error code 137 is being caused by this test or not. If we deactivate this for only a few platforms, we may still see hits and won't know for sure if this was the cause.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it also affecting Windows coreclr?

I sampled the errors in the Report table, and all seem to be a Linux flavor using CoreCLR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failures for the tracking issue will always be for Linux because the 137 exit code in the error message pattern is a Linux behavior.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mkay. Approving!

@jozkee jozkee merged commit c2efebf into dotnet:main Aug 30, 2024
85 checks passed
@jozkee jozkee deleted the disable-test-100558 branch August 30, 2024 02:50
@jozkee
Copy link
Member Author

jozkee commented Sep 3, 2024

/backport to release/9.0

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10686471987

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants