-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable MemoryStream_SeekOverflow_Throws on Linux #107163
Conversation
Tagging subscribers to this area: @dotnet/area-system-io |
[ActiveIssue("https://github.com/dotnet/runtime/issues/100225", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.IsX64Process))] | ||
[ActiveIssue("https://github.com/dotnet/runtime/issues/100558", TestPlatforms.Linux)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we want to have more than one ActiveIssue.
The previous ActiveIssue deactivated the test in mono, windows, x64.
The current ActiveIssue is deactivating the test in all runtimes, in all architectures, but only in Linux. Isn't it also affecting Windows coreclr?
I think we should deactivate this test for everything. No platform filters. That way we can be 100% sure if the error code 137 is being caused by this test or not. If we deactivate this for only a few platforms, we may still see hits and won't know for sure if this was the cause.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it also affecting Windows coreclr?
I sampled the errors in the Report table, and all seem to be a Linux flavor using CoreCLR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failures for the tracking issue will always be for Linux because the 137 exit code in the error message pattern is a Linux behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mkay. Approving!
/backport to release/9.0 |
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10686471987 |
Disabling test to see if it relieves CI.
See #100558 (comment).