Fix handling of appending keywords to boolean schemas. #108246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is pending verification from @SergeyMenshykh that this fixes microsoft/semantic-kernel#8983 |
stephentoub
reviewed
Sep 25, 2024
src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchema.cs
Show resolved
Hide resolved
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/11038683960 |
4 tasks
stephentoub
approved these changes
Sep 25, 2024
3 tasks
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/ba-g license/cla is in a stuck state. |
|
@dotnet-policy-service rerun |
|
@dotnet-policy-bot rerun |
|
@dotnet-policy-service rerun |
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
* Fix handling of appending keywords to boolean schemas. * Add a few comments documenting boolean schemas.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix microsoft/semantic-kernel#8983. Replicated in eiriktsarpalis/stj-schema-mapper#6. Should be backported to .NET 9.