[release/8.0-staging] Tweak Invariant IndexOf logic #108729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
tarekgh
approved these changes
Oct 9, 2024
tarekgh
added
Servicing-approved
|
This is approved by email. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #108709 to release/8.0-staging
/cc @tarekgh @MihaZupan
Customer Impact
This is accumulated change for previous change #108563. To address the perf regression occurred with the original change.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Manually measured the perf and collected the benchmark. Passed all regression tests including the tests added with the original change.
Risk
Low, the change here is really moving the declaration of a span variable inside the method to the bottom of the method. No actual logic or behavior change.