[release/9.0] Ensure a null PublicKey is supported on assembly refs #108928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
needs-area-label
steveharter
added
area-VM-coreclr
and removed
needs-area-label
|
Tagging subscribers to this area: @mangod9 |
jkoritzinsky
approved these changes
Oct 16, 2024
jeffschwMSFT
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #108907 to release/9.0.
Issue: #108517
Customer Impact
Certain DispatchProxy scenarios and consumers including WCF are broken in v9 when referencing assemblies that do not have a PublicKey. One potential workaround is to add a PublicKey to the referenced assembly, however that is not viable in all cases since the target assembly may external.
Regression
See the linked issue - when generating an assembly through DispatchProxy, an assembly reference that has a
nullPublicKey may instead be generated with a random PublicKey. This will later cause that referenced assembly to not be loaded properly.Testing
The original issue was verified.
Risk
Low; the regression was made in v9 and the fix is straightforward.