Move MonoClass:inlinearray_value out of MonoClass

[syfFerdinand]

Summary

This PR addresses issue #103913 by moving the inlinearray_value property from MonoClass to the infrequent_data structure. This change aims to optimize memory usage by storing rarely used properties in a less frequently accessed structure.

Details

• Moved inlinearray_value from MonoClass to MonoPropertyBag within the infrequent_data structure.
• Set explicit value for PROP_INLINEARRAY_VALUE in InfrequentDataKind enum, as per review comments.
• Updated relevant getters and setters to reflect the new structure.
• Marked mono_class_get_inlinearray_value with MONO_COMPONENT_API as per review suggestion to ensure proper export when compiled as shared libraries.
• Modified all occurrences of inlinearray_value access to use the new structure.
• Performed testing to ensure no functionality is broken due to this change.

Related Issue

Fixes #103913

[syfFerdinand]

@dotnet-policy-service agree

[lambdageek]

Thanks for the contribution @syfFerdinand !

[lambdageek]

/cc @steveisok

[steveisok]

@kg can you please give this a review?

[steveisok]

Can you see https://dev.azure.com/dnceng-public/public/_build/results?buildId=865527&view=artifacts&pathAsName=false&type=publishedArtifacts ? I believe there are downloads for the offsets there, which might be what you need.

Note #109612 added the actual offset files. Any updates should go into these.

[syfFerdinand]

Hi @kg and @steveisok,
Just to confirm, my current code in the src/mono/mono/offsets directory should be updated to match the downloaded offset files, right?

[kg]

I've never dealt with this problem before, but it appears that if you download each of the offsets artifacts I linked to, it will be a ZIP file with updated versions of the .h files in it. You would then check in these new .h files to update the offsets. I don't think you want to manually edit the offsets.

[steveisok]

I've never dealt with this problem before, but it appears that if you download each of the offsets artifacts I linked to, it will be a ZIP file with updated versions of the .h files in it. You would then check in these new .h files to update the offsets. I don't think you want to manually edit the offsets.

Unless I'm completely mistaken, we don't auto-generate the offsets any longer and they need to be updated in tree.

@akoeplinger is that correct?

[akoeplinger]

We generate them in PR builds so you can just download and check in the updated offsets, like @kg mentioned.

This is the message on the build, let me know if I can make it clearer:

Detected changes in Mono offsets files. When running in a PR build you can download the MonoAOTOffsets artifacts and update the files in the src/mono/mono/offsets folder.

edit I just noticed that the name of the artifacts in the message is not right, it's Mono_Offsets_<platform> right now

[syfFerdinand]

Thank you all for your assistance and guidance throughout this process. I have updated the offset files with the latest versions from the build artifacts and committed the changes.

Is there anything else that needs to be corrected or adjusted?

[kg]

Once the necessary tests pass I think we should be good. I'll keep an eye on it.

[syfFerdinand]

hi @kg,
I think the tests that are currently failing had been deactivated in this merge... #108178 so I don't understand why there's still this build error...

[kg]

Out of memory issues on the wasm lanes are common, so I don't think the librarytests lane failure indicates a bug you created.

[kg]

Thank you for your contribution!