-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace DAMT.All with more restricted annotation on InvokeMember/FindMembers/DeclaredMembers #109801
Conversation
…Members/DeclaredMembers
Note regarding the
|
1 similar comment
Note regarding the
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar |
@dotnet/illink @eerhardt anyone could have a look please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think the breaking change is acceptable - should be rare for anyone to hit this, and if they do, fixing the annotations to match this would be an improvement.
/ba-g deadlettered test |
I'm looking at places we use .All to see if the new annotations could help. Here we don't need the new annotations, this was always expressible. I can only assume the reason for .All was laziness. This was at a time when we believed .All "just keeps a bit more" and we didn't consider the impact of marking interface methods implemented by the class, or the impact of warnings due to .All capturing things that are not safe to reflection-call.
This is a breaking change in theory, should someone implement
IReflect
or derive fromSystem.TypeInfo
- they need to update the annotations.Cc @dotnet/illink @eerhardt