[wasm] Use correct current runtime pack version for Wasm.Build.Tests #109836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
requested review from
ilonatommy,
lewing and
pavelsavara
as code owners
akoeplinger
approved these changes
Nov 14, 2024
| <ItemGroup> | ||
| <_RuntimePackVersions Include="$(PackageVersion)" EnvVarName="RUNTIME_PACK_VER9" /> | ||
| <_RuntimePackVersions Include="$(_RuntimePackCurrentVersion)" EnvVarName="RUNTIME_PACK_VER9" /> |
There was a problem hiding this comment.
we need to update this to RUNTIME_PACK_VER10 at some point right? do you know if we have a tracking issue somewhere?
There was a problem hiding this comment.
We don't. Maybe be better than tracking issue is to write it down to some wiki "All wasm steps for new TFM"™️.
|
This test shouldn't have failed https://helix.dot.net/api/2019-06-17/jobs/42eee7bb-58b1-4b33-ace4-35a44ee56d6b/workitems/NoWorkload-ST-Wasm.Build.Tests/console. Also, the required sub-string is visible in the output... |
|
@maraf I've seen this happening a couple times, there is some race condition where the stdout doesn't get read completely before we're checking for the substring. I bet it will pass when you rerun tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasm.Build.Tests are not a shipping project, PackageVersion will have a version suffix even for release branch, where actual runtime pack version doesn't have version suffix. Use ProductVersion in that case, based on StabilizePackageVersion value.
Forwardport of #109820