Warn if RequiresXXXCode is placed on an entrypoint #110185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#109811. Motivated by real-world first party code that did this :(.
MichalStrehovsky
requested review from
marek-safar and
sbomer
as code owners
| @@ -128,6 +128,11 @@ internal static MessageContainer CreateErrorMessage(MessageOrigin? origin, Diagn | |||
| if (context.IsWarningSubcategorySuppressed(subcategory)) | |||
| return null; | |||
|
|
|||
| // If the warning comes from compiler-generated code, it would not be actionable. The assumption is that | |||
| // compiler-generated code doesn't have issues. | |||
| if (origin.MemberDefinition is MethodDesc originMethod && originMethod.GetTypicalMethodDefinition() is not EcmaMethod) | |||
There was a problem hiding this comment.
ILC generates a method that calls user's main (after initializing the environment). It was triggering a warning if Main has RUC
| @@ -203,5 +203,27 @@ public static bool IsConstructor ([NotNullWhen (returnValue: true)] this ISymbol | |||
|
|
|||
| public static bool IsStaticConstructor ([NotNullWhen (returnValue: true)] this ISymbol? symbol) | |||
| => (symbol as IMethodSymbol)?.MethodKind == MethodKind.StaticConstructor; | |||
|
|
|||
| public static bool IsEntryPoint (this IMethodSymbol methodSymbol, Compilation compilation) | |||
| => methodSymbol.Name is WellKnownMemberNames.EntryPointMethodName or WellKnownMemberNames.TopLevelStatementsEntryPointMethodName && | |||
There was a problem hiding this comment.
This is how Roslyn does it in same named method. It might be overly broad in edge cases. Not sure how much we care, it's pretty niche.
jtschuster
approved these changes
Nov 26, 2024
MichalStrehovsky
added
area-Tools-ILLink
Yeah, that's a lot of extra docs and messages to write. This should be rare enough that it doesn't matter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109811.
Motivated by real-world first party code that did this :(.
Cc @dotnet/illink