Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Remove CoreFX.issues_windows.rsp file #32592

Merged
merged 84 commits into from
Apr 10, 2020

Conversation

MaximLipnin
Copy link
Contributor

@MaximLipnin MaximLipnin commented Feb 20, 2020

Changes:

  • enabled runtime (Libraries Test Run release mono Windows_NT x64 Debug) CI lane (Windows Nano Server CI leg is disabled);
  • enabled the tests that pass;
  • marked failing test assemblies/classes/methods with ActiveIssue attribute using respective GH issues;
  • removed CoreFX.issues_windows.rsp file and related mono rsp arguments.

Part of #1980

@MaximLipnin
Copy link
Contributor Author

#33549

@MaximLipnin
Copy link
Contributor Author

MaximLipnin commented Mar 17, 2020

@ViktorHofer Could you please help here? I'm trying to enable runtime (Libraries Test Run release mono Windows_NT x64 Debug) lane at least with the current rsp file, yet it still fails. Not sure if it's the cause but all the logs contain the following:

Failed to load the dll from [C:\helix\work\correlation\shared\Microsoft.NETCore.App\5.0.0\coreclr.dll], HRESULT: 0x8007007E
Failed to bind to CoreCLR at 'C:\helix\work\correlation\shared\Microsoft.NETCore.App\5.0.0\'
Failed to create CoreCLR, HRESULT: 0x80008088
----- end Mon 03/16/2020 20:59:12.03 ----- exit code -2147450743 ----------------------------------------------------------

I don't have it locally, at least for some namespaces which I've tried

@MaximLipnin
Copy link
Contributor Author

According to @lateralusX, the possible cause is that:

Windows mono runtime has a dependency on c-runtime DLL, and if a different machine is running tests compare to build machine that redist needs to be installed and available, or you will get failures to load coreclr.dll due to missing dependencies. CoreCLR uses static c-runtime dependency ..., but Mono in the past always used dynamic linked c-runtime (since that has been a recommendation for ages).

@lateralusX
Copy link
Member

I will do the change to build using static c-runtime for Mono runtime since that was in the plan aligning to CoreCLR redist requirements. Since the failing lane is running debug Mono runtime, I strongly believe issue is related to this, since debug c-runtime is seldom available on host that don't have full toolchain installed.

@lateralusX
Copy link
Member

#33715

@MaximLipnin MaximLipnin force-pushed the remove_windows_rsp branch 3 times, most recently from 86c24c3 to 934fdec Compare March 19, 2020 11:27
@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 19, 2020

@MaximLipnin sounds like your are unblocked?

@MaximLipnin
Copy link
Contributor Author

@ViktorHofer Unfortunately, no. According to the latest log, there are over 400 errors, and the crashes mentioned above still occur. Perhaps, @lateralusX will try another fix for that (in addition to what he has already done).

@lateralusX
Copy link
Member

CoreCLR seems to static link vcruntime140.dll even in release builds (not default behaviour when using /MD compiler switch). Looking at the install package that library is not included and since we still need it, I believe that is why we still fail to load, due to missing dependency. Problem is not seen if the c-runtime redist exists and I believe CI don't have that installed. I will try to do same thing as CoreCLR does static link vcruntime140.dll to reduce dependencies not included in package.

@lateralusX
Copy link
Member

This should get rid of the vcruntime140.dll runtime dependecy:

#33853

…tsInOneStream and System.Runtime.Serialization.Formatters.Tests.ValidateBasicObjectsRoundtrip with ActiveIssue
…meBufferExtensionsTests and System.Runtime.InteropServices.WindowsRuntime.Tests.WindowsRuntimeBufferTests test classes with ActiveIssue
@MaximLipnin MaximLipnin marked this pull request as ready for review April 10, 2020 07:21
Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@akoeplinger akoeplinger merged commit ab6e225 into dotnet:master Apr 10, 2020
@MaximLipnin MaximLipnin deleted the remove_windows_rsp branch April 10, 2020 11:26
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants