-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono] Remove CoreFX.issues_windows.rsp file #32592
Conversation
6d6236d
to
cd11f87
Compare
5c546fe
to
d36caa8
Compare
@ViktorHofer Could you please help here? I'm trying to enable
I don't have it locally, at least for some namespaces which I've tried |
According to @lateralusX, the possible cause is that:
|
I will do the change to build using static c-runtime for Mono runtime since that was in the plan aligning to CoreCLR redist requirements. Since the failing lane is running debug Mono runtime, I strongly believe issue is related to this, since debug c-runtime is seldom available on host that don't have full toolchain installed. |
86c24c3
to
934fdec
Compare
@MaximLipnin sounds like your are unblocked? |
@ViktorHofer Unfortunately, no. According to the latest log, there are over 400 errors, and the crashes mentioned above still occur. Perhaps, @lateralusX will try another fix for that (in addition to what he has already done). |
934fdec
to
f30f946
Compare
CoreCLR seems to static link vcruntime140.dll even in release builds (not default behaviour when using /MD compiler switch). Looking at the install package that library is not included and since we still need it, I believe that is why we still fail to load, due to missing dependency. Problem is not seen if the c-runtime redist exists and I believe CI don't have that installed. I will try to do same thing as CoreCLR does static link vcruntime140.dll to reduce dependencies not included in package. |
This should get rid of the vcruntime140.dll runtime dependecy: |
f30f946
to
af4efc2
Compare
af4efc2
to
93d2e0e
Compare
93d2e0e
to
c58a82c
Compare
51d5fd4
to
aeca60e
Compare
811271d
to
946c04a
Compare
…tsInOneStream and System.Runtime.Serialization.Formatters.Tests.ValidateBasicObjectsRoundtrip with ActiveIssue
… class with ActiveIssue
…meBufferExtensionsTests and System.Runtime.InteropServices.WindowsRuntime.Tests.WindowsRuntimeBufferTests test classes with ActiveIssue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
…dows (#34816) Follow-up to #32592 (review).
Changes:
runtime (Libraries Test Run release mono Windows_NT x64 Debug)
CI lane (Windows Nano Server CI leg is disabled);ActiveIssue
attribute using respective GH issues;Part of #1980