fix endless loop in GetActiveUdpListeners #35078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
davidsh
approved these changes
Apr 16, 2020
|
sorry @jkotas . I missed that somehow. I shall not merge late night ;( |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like regression caused by #1914. It removed
buffer = SafeLocalAllocHandle.LocalAlloc((int)size)from SystemIPGlobalProperties.cs / GetActiveUdpListeners() so when initial allocation fails we never allocate more bytes and we loop endlessly.Tcp counterpart seems fine.
I originally added some of the test as part of specific unix fixes. But they run fine on Windows as well and I checked and they would catch the regression. So I'm removing the Unix restriction.
fixes #35051