[release/6.0-preview2] Turn off LKG calculation #49075
Conversation
This change moves the performance infrastructure to use the latest version of dotnet for building and running BDN. This does not change what bits are tested.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Not sure who I need to tag here or what the process for infrastructure changes are in release branches. @danmoseley |
|
Could you share why you're backporting ? I don't have an objection in principle. If you need this in order to have official numbers for preview 2, that seems a necessary part of shipping, and this is approved to merge. |
|
Yes, this is because we added the PriortityQueue tests, and the version of dotnet that we were using before cannot build the tests because it does not contain the type. I am going to do more validation to make sure that this fully fixes the issue, and then I will merge here. |
|
Actually, it just occurs to me that the last code for Preview 2 has presumably left this repo now... you presumably don't need your change in the product, but we should check that the branch is open. (@mmitche ?) |
|
We still have a couple days if necessary, but under QB approval mode now. |
|
How do I get QB approval? I would really like to be able to get working runs out of this branch. |
|
My understanding is that the QB in this case is M2 - ie me. So unless @mmitche says otherwise, you can merge when tested/reviewed/green. |
|
Sorry at @danmoseley, but can you re-approve this? I had to make some changes to do some testing and then took them out, but that reset the approval. |
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsThis change moves the performance infrastructure to use
|
ghost
locked as resolved and limited conversation to collaborators
This change moves the performance infrastructure to use
the latest version of dotnet for building and running BDN.
This does not change what bits are tested.