-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix redhat arm64 #52244
Merged
Merged
Fix redhat arm64 #52244
Commits on Jul 15, 2021
-
Clang on ARM64 places the .rodata section into the same segment as .text. On RHEL 8 ARM64, the kernel is configured for 64kB memory pages. When we flip the page protection of the page containing the GS cookie to RW and back to RO, we assume that the cookie lives in a non-executable memory. This assumption is broken on RHEL 8 and we end up setting protection of a part of the coreclr code to read only instead of back to RX. This change switches the linker we use to lld from the previously used gnu linker. That linker places .rodata into a different segment than .text by default. Moreover, I was planning to move to using lld anyways to use all build tools from LLVM.
Configuration menu - View commit details
-
Copy full SHA for fef1a9e - Browse repository at this point
Copy the full SHA fef1a9eView commit details -
Fix ARM build to use PC relative addresses only
The lld linker has revealed that we were using absolute addresses in some asm helpers and so load time relocation was necessary. This change fixes it by replacing all of those by PC relative ones.
Configuration menu - View commit details
-
Copy full SHA for 285cada - Browse repository at this point
Copy the full SHA 285cadaView commit details -
Update docker images used for building runtime
Use new images that have lld linker
Configuration menu - View commit details
-
Copy full SHA for 9970b60 - Browse repository at this point
Copy the full SHA 9970b60View commit details -
There is no support for lld on that platform yet
Configuration menu - View commit details
-
Copy full SHA for 3bd6fbf - Browse repository at this point
Copy the full SHA 3bd6fbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0433807 - Browse repository at this point
Copy the full SHA 0433807View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ea2887 - Browse repository at this point
Copy the full SHA 1ea2887View commit details -
Move LLD configuration into configuretools.cmake
Also update PGO stuff to not to use gold linker when lld is present.
Configuration menu - View commit details
-
Copy full SHA for 9bfa3a0 - Browse repository at this point
Copy the full SHA 9bfa3a0View commit details
Commits on Jul 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 99aa111 - Browse repository at this point
Copy the full SHA 99aa111View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09c5999 - Browse repository at this point
Copy the full SHA 09c5999View commit details
Commits on Jul 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f1abcd3 - Browse repository at this point
Copy the full SHA f1abcd3View commit details
Commits on Jul 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e66eb50 - Browse repository at this point
Copy the full SHA e66eb50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33bb47c - Browse repository at this point
Copy the full SHA 33bb47cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d1e65d - Browse repository at this point
Copy the full SHA 3d1e65dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f0ff6d - Browse repository at this point
Copy the full SHA 5f0ff6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bad50b6 - Browse repository at this point
Copy the full SHA bad50b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c4e740 - Browse repository at this point
Copy the full SHA 0c4e740View commit details
Commits on Jul 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3856661 - Browse repository at this point
Copy the full SHA 3856661View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.