Fix Win arm GC barrier stuff #56585
Merged
Fix Win arm GC barrier stuff #56585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dotnet/jit-contrib |
AndyAyersMS
approved these changes
Jul 29, 2021
|
/azp run R2R-CG2 windows arm Checked |
|
No pipelines are associated with this pull request. |
|
We should, but I don't know how to launch it. |
davidwrighton
approved these changes
Jul 29, 2021
|
I think it's just /azp run runtime-coreclr outerloop |
janvorli
force-pushed
the
fix-win-arm64-gcbarrier
branch
from
f009495 to
6e32bc3
Compare
My recent change to enable using LLD on Unix inadvertedly broken Windows ARM GC barriers. This change makes part of that change Unix specific.
janvorli
force-pushed
the
fix-win-arm64-gcbarrier
branch
from
6e32bc3 to
e24e9f7
Compare
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Some of the outerloop test legs have failed due to some infra issues, but the Windows arm test leg that we needed to run completed green. Merging... |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My recent change to enable using LLD on Unix inadvertedly broken
Windows ARM GC barriers. This change makes part of that change
Unix specific, reverting the Windows state to the previous way.
Close #56570