Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from mono/linker #57203

Merged
merged 8 commits into from
Aug 14, 2021
Merged

[main] Update dependencies from mono/linker #57203

merged 8 commits into from
Aug 14, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 11, 2021 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/mono/linker

  • Subscription: 0d6d6ae4-f71f-4395-53e6-08d8e409d87d
  • Build: 20210811.3
  • Date Produced: 8/11/2021 9:15 PM
  • Commit: 5d376b1f8963c5c0013482ec63d857d359658809
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210811.1
b8f4460 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21409.3 -> To Version 6.0.100-preview.6.21411.1
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@lewing
Copy link
Member

lewing commented Aug 11, 2021

cc @vitek-karas

@lewing lewing added the area-codeflow for labeling automated codeflow label Aug 11, 2021
@lewing
Copy link
Member

lewing commented Aug 11, 2021

It looks like 7bf5cd4505d6c36f6c33984789e2a23b8837b6f1 broke the tool?

@lewing
Copy link
Member

lewing commented Aug 11, 2021

same issue in dotnet/sdk#19655

@lewing lewing mentioned this pull request Aug 11, 2021
Merged
@vitek-karas
Copy link
Member

Fix should be in dotnet/linker#2204.

@vitek-karas
Copy link
Member

The fix has been merged to linker as dotnet/linker@272bd6d. It should get picked up by this PR soon.

@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210811.2
d3ab157 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21409.3 -> To Version 6.0.100-preview.6.21411.2
@lewing
Copy link
Member

lewing commented Aug 11, 2021

Now we're blocked by the sdk bump #57143

cc @ViktorHofer @danmoseley

@vitek-karas
Copy link
Member

I can workaround this in the linker to force it to target preview 6 - @ViktorHofer please let me know if you want me to do that or if we will "Wait" for the runtime to catchup to arcade ;-)

@ViktorHofer
Copy link
Member

Let's wait as we need the SDK update anyway asap.

@lewing
Copy link
Member

lewing commented Aug 11, 2021 •
edited
Loading

cc @josalem wrong pr

@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210811.3
5467077 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21409.3 -> To Version 6.0.100-preview.6.21411.3
@ViktorHofer
Copy link
Member

/azp run

@dotnet-maestro dotnet-maestro bot deleted the darc-main-5595dbb7-2b92-4960-9842-d45a343ab956 branch August 13, 2021 07:31
@ViktorHofer ViktorHofer restored the darc-main-5595dbb7-2b92-4960-9842-d45a343ab956 branch August 13, 2021 07:32
@ViktorHofer ViktorHofer reopened this Aug 13, 2021
@ViktorHofer
Copy link
Member

/azp run runtime

@ViktorHofer
Copy link
Member

/azp run dotnet-linker-tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet dotnet deleted a comment from azure-pipelines bot Aug 13, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vitek-karas
Copy link
Member

@eerhardt could you please review the fix 9096bff?

@vitek-karas
Copy link
Member

@sbomer - please take a look at the suppression added in System.Data.OleDb - as a small review.

@sbomer
Copy link
Member

sbomer commented Aug 13, 2021

@vitek-karas Something seems off - I would have expected this suppression to silence the warning before your change:

runtime/src/libraries/System.Data.OleDb/src/ILLink/ILLink.Suppressions.xml

Lines 100 to 105 in 5817dc8

<attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
<argument>ILLink</argument>
<argument>IL2111</argument>
<property name="Scope">member</property>
<property name="Target">M:System.Data.OleDb.OleDbDataReader.BuildSchemaTable(MetaData[])</property>
</attribute> </assembly>

@vitek-karas
Copy link
Member

I completely missed that. Turns out it's was just not written correctly in the XML - so I fixed that (and reverted all my other changes related to this).

sbomer
sbomer approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@sbomer sbomer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting - I wonder why this wasn't hit in #56593 then.

@lewing lewing merged commit 6c39236 into main Aug 14, 2021
@lewing lewing deleted the darc-main-5595dbb7-2b92-4960-9842-d45a343ab956 branch August 14, 2021 18:02
@lewing lewing mentioned this pull request Aug 14, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbomer sbomer sbomer approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lewing @vitek-karas @ViktorHofer @sbomer