Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTTP/3] Fixed H/3 stress server after the last Kestrel change. #57356

Merged
merged 1 commit into from
Aug 16, 2021
Merged

[HTTP/3] Fixed H/3 stress server after the last Kestrel change. #57356

merged 1 commit into from
Aug 16, 2021

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Aug 13, 2021 •
edited
Loading

Note that the stress compiles, runs HTTP/3, but it's full of errors. I don't know if some of them are new after this change, I haven't had time to properly investigate.

Fixes #57351

@ghost
Copy link

ghost commented Aug 13, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Note that the stress compiles, runs HTTP/3, but it's full of errors. I don't know if some of them are new after this change, I haven't had time to properly investigate.

Author: ManickaP
Assignees: -
Labels:

area-System.Net.Http
Milestone: -

@ManickaP
Copy link
Member Author

/azp run runtime-libraries stress-http

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

antonfirsov
antonfirsov approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

CarnaViire
CarnaViire approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManickaP
Copy link
Member Author

So the H/3 stress is reporting System.Net.Http.HttpRequestException: The server returned an invalid or unrecognized response. which looks awfully like #55988. That issue should be fixed in main. @CarnaViire any ideas?

@ManickaP
Copy link
Member Author

And after 2 minutes it crashed with: ##[error]Bash exited with code '139'. 😢

@ManickaP
Copy link
Member Author

This time it ran, I'll merge this because it unblocks other http versions. It's not making the current status worse.

@ManickaP ManickaP merged commit 4f60ea9 into dotnet:main Aug 16, 2021
@ManickaP ManickaP deleted the mapichov/57351_fixed_h3_stress_server branch August 16, 2021 09:02
@CarnaViire
Copy link
Member

😢
The server returned an invalid or unrecognized response. is super strange :( we need to investigate.
And it's not only that, there's tons of aborted Streams and Connections with error code 0, which is also super strange, H3 doesn't have an error code like that, and MsQuicStream's Dispose uses error code 0xffffffff

thaystg added a commit to thaystg/runtime that referenced this pull request Aug 16, 2021
@thaystg
Merge remote-tracking branch 'origin/main' into thays_cache_debugger_…
58cffee 
…information

# By dotnet-maestro[bot] (4) and others
# Via GitHub
* origin/main: (58 commits)
  Localized file check-in by OneLocBuild Task (dotnet#57384)
  [debugger][wasm] Support DebuggerProxyAttribute (dotnet#56872)
  Account for type mismatch of `FIELD_LIST` members in LSRA (dotnet#57450)
  Qualify `sorted_table` allocation with `nothrow` (dotnet#57467)
  Rename transport packages to follow convention (dotnet#57504)
  Generate proper DWARF reg num for ARM32 (dotnet#57443)
  Enable System.Linq.Queryable and disable dotnet#50712 (dotnet#57464)
  Mark individual tests for 51211 (dotnet#57463)
  Fix Length for ReadOnlySequence created out of sliced Memory owned by MemoryManager (dotnet#57479)
  Add JsonConverter.Write/ReadAsPropertyName APIs (dotnet#57302)
  Remove workaround for dotnet/sdk#19482 (dotnet#57453)
  Do not drain HttpContentReadStream if the connection is disposed (dotnet#57287)
  [mono] Fix a few corner case overflow operations (dotnet#57407)
  make use of ports in SPN optional (dotnet#57159)
  Fixed H/3 stress server after the last Kestrel change (dotnet#57356)
  disable a failing stress test. (dotnet#57473)
  Eliminate temporary byte array allocations in the static constructor of `IPAddress`. (dotnet#57397)
  Update dependencies from https://github.com/dotnet/emsdk build 20210815.1 (dotnet#57447)
  [main] Update dependencies from mono/linker (dotnet#57344)
  Improve serializer performance (dotnet#57327)
  ...

# Conflicts:
#	src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
#	src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
#	src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs
@karelz karelz added this to the 6.0.0 milestone Aug 17, 2021
@CarnaViire CarnaViire mentioned this pull request Aug 18, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonfirsov antonfirsov antonfirsov approved these changes

@CarnaViire CarnaViire CarnaViire approved these changes

@wfurt wfurt Awaiting requested review from wfurt

Assignees
No one assigned
Labels
area-System.Net.Http
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

HttpStress build broken by a kestrel change (QuicTransportOptions.Alpn removed)
4 participants
@ManickaP @CarnaViire @antonfirsov @karelz