Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip ExportPkcs7_Empty test on mobile platforms #59626

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Skip ExportPkcs7_Empty test on mobile platforms #59626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c049db2
Skip ExportPkcs7_Empty test on mobile platforms
Sep 26, 2021
8d6bc73
PKCS7_Empty was failing on android b/c 0 length was not allowed. See…
Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/libraries/Native/Unix/System.Security.Cryptography.Native.Android/pal_x509.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ int32_t AndroidCryptoNative_X509ExportPkcs7(jobject* /*X509Certificate[]*/ certs
int32_t* outLen)
{
abort_if_invalid_pointer_argument (certs);
abort_if_negative_integer_argument (certsLen);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems distinct from disabling a test... should it really be part of the same change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can throw up a separate PR. I originally thought it was going to skip android, but realized it was failing for a completely different reason.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, OK, so this is fixing Android and disabling it on iOS/tvOS.

Separate changes would be more ideal... but why respin CI?


JNIEnv* env = GetJNIEnv();

Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Security.Cryptography.X509Certificates/tests/CollectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1549,6 +1549,7 @@ public static void ImportFromPem_NonCertificateContent_Pkcs7_Fails()
}

[Fact]
[SkipOnPlatform(PlatformSupport.MobileAppleCrypto, "PKCS#7 export is not available")]
public static void ExportPkcs7_Empty()
{
X509Certificate2Collection cc = new X509Certificate2Collection();
Expand Down