Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: increase slop tolerance when computing edge weights #76409

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

AndyAyersMS
Copy link
Member

@AndyAyersMS AndyAyersMS commented Sep 29, 2022

Up the tolerance a bit to get past some jit stress errors we're seeing.

Fixes the main case in #74169.

Diffs

Up the tolerance a bit to get past some jit stress errors we're seeing.

Fixes the main case in dotnet#74169.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 29, 2022
@ghost ghost assigned AndyAyersMS Sep 29, 2022
@ghost
Copy link

ghost commented Sep 29, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Up the tolerance a bit to get past some jit stress errors we're seeing.

Fixes the main case in #74169.

Author: AndyAyersMS
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@AndyAyersMS
Copy link
Member Author

@BruceForstall PTAL
cc @dotnet/jit-contrib

I'm hoping all this code will go away in .NET 8. So, I'm willing to apply band-aids for now.

@AndyAyersMS
Copy link
Member Author

There may be some diffs from this; we will see shortly.

@AndyAyersMS
Copy link
Member Author

There may be some diffs from this; we will see shortly.

There were a few.. see link above.

@AndyAyersMS
Copy link
Member Author

SPMI replay failure is an arm timeout, assuming this is unrelated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants