Fix SuperPMI unit test error checking #76411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsWe were ignoring test failures, and even ignoring if the test we wanted to run under collection actually existed. This means that at some point during recent test reconfigurations, we stopped building 10w5d_cs_do.cmd/sh but we didn't notice. Because Bytemark kept being built as before, we got at least some .mc files. Add more checking that the programs we want to run exist, and that the tests we invoke pass.
|
We were ignoring test failures, and even ignoring if the test we wanted to run under collection actually existed. This means that at some point during recent test reconfigurations, we stopped building 10w5d_cs_do.cmd/sh but we didn't notice. Because Bytemark kept being built as before, we got at least some .mc files. Add more checking that the programs we want to run exist, and that the tests we invoke pass.
Add CscBench to get better C# coverage. Disable 10w5d_cs_do.csproj due to dotnet#76421
BruceForstall
force-pushed
the
AdditionalSpmiUnitTestVerification
branch
from
68c5a25
to
5d32ee8
Compare
|
@jakobbotsch @dotnet/jit-contrib PTAL |
jakobbotsch
approved these changes
Oct 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were ignoring test failures, and even ignoring if the test we wanted to run under collection actually existed. This means that at some point during recent test reconfigurations, we stopped building 10w5d_cs_do.cmd/sh but we didn't notice. Because Bytemark kept being built as before, we got at least some .mc files.
Add more checking that the programs we want to run exist, and that the tests we invoke pass.
Adjust superpmi unit test collection tests: