Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mono: Replace exception strings with those stored in the resx file (#34056) #78341

Merged
merged 25 commits into from
Mar 23, 2023
Merged

Mono: Replace exception strings with those stored in the resx file (#34056) #78341

merged 25 commits into from
Mar 23, 2023

Commits on Nov 14, 2022

  1. swapping exception strings from resx file

    @databunks
    databunks committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    0d46864 View commit details
    Browse the repository at this point in the history

  2. Fixed byref naming/text value 

    Fixed 2nd parameter for argumentExceptions
    @databunks
    databunks committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    e276c22 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Fixed ByRef Arguments & 

    string.format -> SR.Format
    @databunks
    databunks committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    bf792d9 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. fixes SRformat only used in exceptions & resx refs

    @databunks
    databunks committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    9838ae5 View commit details
    Browse the repository at this point in the history

  2. fixing small typo

    @databunks
    databunks committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    3eeec78 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2022

  1. de-duplication + suggested changes

    @databunks
    databunks committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    98392ba View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Remaining strings fix

    @databunks
    databunks committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    37a5ea7 View commit details
    Browse the repository at this point in the history

  2. global members merge conflict fix

    @databunks
    databunks committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    7bd6987 View commit details
    Browse the repository at this point in the history

  3. Remaining Merge Conflict fixes

    @databunks
    databunks committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    7f67478 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into main

    @databunks
    databunks authored Dec 16, 2022
    Configuration menu
    Copy the full SHA
    95168c2 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Apply suggestions from code review

    @akoeplinger
    akoeplinger authored Jan 23, 2023
    Configuration menu
    Copy the full SHA
    cf88b72 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Merge branch 'main' into databunks/main 

    # Conflicts:
#	src/mono/System.Private.CoreLib/src/System/Reflection/Emit/DerivedTypes.Mono.cs
#	src/mono/System.Private.CoreLib/src/System/Reflection/Emit/MethodOnTypeBuilderInst.cs
#	src/mono/System.Private.CoreLib/src/System/Reflection/Emit/RuntimeTypeBuilder.Mono.cs
#	src/mono/System.Private.CoreLib/src/System/Reflection/Emit/TypeBuilderInstantiation.cs
    @akoeplinger
    akoeplinger committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    2af909b View commit details
    Browse the repository at this point in the history

  2. Fix merge conflicts

    @akoeplinger
    akoeplinger committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    4ee4128 View commit details
    Browse the repository at this point in the history

  3. PR feedback

    @akoeplinger
    akoeplinger committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    061e2ea View commit details
    Browse the repository at this point in the history

  4. Fix Argument_MissingDefaultConstructor usages

    @akoeplinger
    akoeplinger committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    44af1ba View commit details
    Browse the repository at this point in the history

  5. Fix remaining usages of exception strings

    @akoeplinger
    akoeplinger committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    5f8c018 View commit details
    Browse the repository at this point in the history

  6. Remove unused resources and fix one usage

    @akoeplinger
    akoeplinger committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    80dd633 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Dan Moseley <[email protected]>
    @akoeplinger @danmoseley
    akoeplinger and danmoseley authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    1ef9d27 View commit details
    Browse the repository at this point in the history

  8. Deduplicate some strings

    @akoeplinger
    akoeplinger committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    637e1e1 View commit details
    Browse the repository at this point in the history

  9. Fixup string

    @akoeplinger
    akoeplinger committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    01f8e4e View commit details
    Browse the repository at this point in the history

  10. Fix errors in resource strings

    @akoeplinger
    akoeplinger committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    c1b501c View commit details
    Browse the repository at this point in the history

  11. Update src/libraries/System.Private.CoreLib/src/Resources/Strings.resx 

    Co-authored-by: Dan Moseley <[email protected]>
    @akoeplinger @danmoseley
    akoeplinger and danmoseley authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    f38e86e View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Merge branch main into databunks/main 

    # Conflicts:
#	src/mono/System.Private.CoreLib/src/Mono/RuntimeMarshal.cs
    @akoeplinger
    akoeplinger committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    27fa647 View commit details
    Browse the repository at this point in the history

  2. Remove unused resource

    @akoeplinger
    akoeplinger committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    5ad8622 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. A few more fixes

    @akoeplinger
    akoeplinger committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    6974e7c View commit details
    Browse the repository at this point in the history