[mono][aot] Optimize constrained calls made from gsharedvt methods. #79339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
This will also avoid some interpreter transitions on wasm, making the stack traces on BCL test suite crashes etc. smaller. |
vargaz
force-pushed
the
constrained-gsharedvt-opt
branch
from
4d41c57
to
03a6dcf
Compare
vargaz
force-pushed
the
constrained-gsharedvt-opt
branch
from
03a6dcf
to
ec5e62d
Compare
|
The failures look relevant. |
|
cc @ivanpovazan @jandupej @kotlarmilos @fanyang-mono --fyi |
vargaz
force-pushed
the
constrained-gsharedvt-opt
branch
from
cbe44f4
to
ef2aec6
Compare
kotlarmilos
reviewed
Dec 9, 2022
kotlarmilos
reviewed
Dec 9, 2022
vargaz
force-pushed
the
constrained-gsharedvt-opt
branch
from
5229775
to
f144a24
Compare
ivanpovazan
reviewed
Dec 10, 2022
| * do an indirect call. | ||
| */ | ||
| calls [0] = NULL; | ||
| // FIXME: Add more cases |
There was a problem hiding this comment.
what would be the additional cases that would fit into the fastpath approach?
There was a problem hiding this comment.
The cases excluded by the if.
There was a problem hiding this comment.
I am trying to understand the code and the effect that covering more cases would bring.
ivanpovazan
reviewed
Dec 12, 2022
vargaz
force-pushed
the
constrained-gsharedvt-opt
branch
from
f144a24
to
03e2564
Compare
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vargaz
added
the
NO-MERGE
|
Failures are relevant. |
vargaz
force-pushed
the
constrained-gsharedvt-opt
branch
from
03e2564
to
8088965
Compare
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vargaz
removed
the
NO-MERGE
|
Failures are unrelated. |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Dec 21, 2022
Closed
vargaz
force-pushed
the
constrained-gsharedvt-opt
branch
2 times, most recently
from
b772123
to
68b30bc
Compare
lambdageek
reviewed
Feb 7, 2023
Comment on lines
+2639
to
+2660
| /* Lookup the virtual method */ | ||
| mono_class_setup_vtable (klass); | ||
| g_assert (m_class_get_vtable (klass)); | ||
| vt_slot = mono_method_get_vtable_slot (cmethod); | ||
| if (mono_class_is_interface (cmethod->klass)) { | ||
| iface_offset = mono_class_interface_offset (klass, cmethod->klass); | ||
| g_assert (iface_offset != -1); | ||
| vt_slot += iface_offset; | ||
| } | ||
| m = m_class_get_vtable (klass) [vt_slot]; | ||
| if (cmethod->is_inflated) { | ||
| m = mono_class_inflate_generic_method_full_checked (m, NULL, mono_method_get_context (cmethod), error); | ||
| return_val_if_nok (error, NULL); | ||
| } | ||
|
|
There was a problem hiding this comment.
We don't have some helper function that does this already?
lambdageek
approved these changes
Feb 7, 2023
The calls are of the form: .constrained T_GSHAREDVT callvirt <method> Whenever T_GSHAREDVT is a reference or value type is only known at runtime. Previously these were handled by passing the arguments to a JIT icall which computed the target method and did a runtime invoke. Added 2 optimizations: * Precompute the data which depends only on the type and the method, store it in an rgctx slot and pass it to the JIT icall. * Add a fastpath for simpler cases which makes an indirect call from generated code.
vargaz
force-pushed
the
constrained-gsharedvt-opt
branch
from
68b30bc
to
0033318
Compare
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Feb 8, 2023
|
Failures are unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calls are of the form:
.constrained T_GSHAREDVT
callvirt
Whenever T_GSHAREDVT is a reference or value type is only known at runtime.
Previously these were handled by passing the arguments to a JIT icall which computed the target method and did a runtime invoke.
Add 2 optimizations: