-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IDesignerSerializationManager
nullability
#79429
Fix IDesignerSerializationManager
nullability
#79429
Conversation
Tagging subscribers to this area: @dotnet/area-system-componentmodel Issue DetailsThe documentation states that many of the functions can return Related: dotnet/winforms#8342, #41720
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The changes look correct to me, but you'll also need to update the corresponding signatures in the ref assembly:
runtime/src/libraries/System.ComponentModel.TypeConverter/ref/System.ComponentModel.TypeConverter.cs
Lines 2188 to 2203 in 4689efa
public partial interface IDesignerSerializationManager : System.IServiceProvider | |
{ | |
System.ComponentModel.Design.Serialization.ContextStack Context { get; } | |
System.ComponentModel.PropertyDescriptorCollection Properties { get; } | |
event System.ComponentModel.Design.Serialization.ResolveNameEventHandler ResolveName; | |
event System.EventHandler SerializationComplete; | |
void AddSerializationProvider(System.ComponentModel.Design.Serialization.IDesignerSerializationProvider provider); | |
object CreateInstance(System.Type type, System.Collections.ICollection arguments, string name, bool addToContainer); | |
object GetInstance(string name); | |
string GetName(object value); | |
object GetSerializer(System.Type objectType, System.Type serializerType); | |
System.Type GetType(string typeName); | |
void RemoveSerializationProvider(System.ComponentModel.Design.Serialization.IDesignerSerializationProvider provider); | |
void ReportError(object errorInformation); | |
void SetName(object instance, string name); | |
} |
...ypeConverter/src/System/ComponentModel/Design/Serialization/IDesignerSerializationManager.cs
Outdated
Show resolved
Hide resolved
...ypeConverter/src/System/ComponentModel/Design/Serialization/IDesignerSerializationManager.cs
Show resolved
Hide resolved
...ypeConverter/src/System/ComponentModel/Design/Serialization/IDesignerSerializationManager.cs
Show resolved
Hide resolved
...ypeConverter/src/System/ComponentModel/Design/Serialization/IDesignerSerializationManager.cs
Outdated
Show resolved
Hide resolved
...ypeConverter/src/System/ComponentModel/Design/Serialization/IDesignerSerializationManager.cs
Show resolved
Hide resolved
Failed test is unrelated afaik. |
The documentation states that many of the functions can return
null
. So I have updated the nullability based on the documentation.https://learn.microsoft.com/en-us/dotnet/api/system.componentmodel.design.serialization.idesignerserializationmanager?view=net-7.0
Related: dotnet/winforms#8342, #41720