[mono] Fix crash when GetDelegateForFunctionPointer is passed non delegate type #79744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egate type When GetDelegateForFunctionPointer is invoked with non delegate type. It iterates over all the methods available to check if these methods are present. "Invoke" method is one such method which is executed by the coreCLR for any type of delegates. Having said that with non delegate "Invoke" method is not supported hence "mono_class_get_method_from_name_checked" returns NULL. Handle this case whenever mono_class_get_method_from_name_checked returns NULL for any methods which are not supported.
giritrivedi
requested review from
vargaz,
lambdageek and
thaystg
as code owners
ghost
added
the
community-contribution
vargaz
approved these changes
Dec 17, 2022
|
How can this happen ? Marshal.GetDelegateForFunctionPointer () checks that the type is a delegate type. |
|
This is specifically crashed when multicastDelegate type is passed to Marshal.GetDelegateForFunctionPointer(). |
|
@lambdageek , @thaystg Can you check the changes and review please. ? |
|
Could you please add/enable a test for this change? |
|
Apparently, passing MulticastDelegate is allowed according to this comment in Marshal.cs: |
|
There is already an existing test case RunGetDelForFcnPtrTest available in file FunctionPointer.cs which tests this scenario as Marshal.GetDelegateForFunctionPointer(fcnptr, typeof(MulticastDelegate)). |
|
Hi, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When GetDelegateForFunctionPointer is invoked with non-delegate type, it iterates over all the methods available to check if these methods are present. "Invoke" method is one such method which is executed by the coreCLR for any type of delegates. Having said that with non-delegate's "Invoke" method is not supported hence "mono_class_get_method_from_name_checked" returns NULL. Handle this case whenever mono_class_get_method_from_name_checked returns NULL for any methods which are not supported.