Transform local indirections off of TYP_BLK locals; support numbering exposed LCL_FLDs
#79771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsThe two changes help to fix the CQ gap that exists today between Positive diffs are expected, with some regressions due to the usual reasons associated with more CSEing.
|
SingleAccretion
force-pushed
the
Blk-Vars
branch
from
cd52ddd
to
225eb65
Compare
Closed
|
This will unblock #79722. |
|
@dotnet/jit-contrib |
|
/azp run runtime-coreclr superpmi-asmdiffs, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, Fuzzlyn |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
The failures look like they might be related? |
|
Taking a look... Edit: the bug has been identified and fixed. |
Good on me for noticing it a few weeks ago in dotnet#79722... ``` // Otherwise, must be local lhs form. TODO-Bug: this doesn't account for LCL_FLD. // This will miss memory havoc induced by address-exposed local field stores. ```
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Jan 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two changes help to fix the CQ gap that exists today between
LCL_FLDandIND(LCL_ADDR)forms of access to address-exposed locals.Positive diffs, with some regressions due to the usual reasons associated with more CSEing (e. g. the large x86 test regressions are actually PerfScore improvements). A bit of a TP regression due to more VNing, will be payed for with #79722.