-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error for missing Python #81202
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsFix #59724
Tested clr and mono on Windows and Linux with and without Python.
|
Before
After
I could suppress the first error, but then it wouldn't handle the case where Python was found, failed, and wrote to stdout. I can't find a way to make that happen but this way you'd still get the first error in such a situation. |
failure was #81249. this is a test failure, so it's downstream of build and this change is validated. |
Fix #59724
Tested clr and mono on Windows and Linux with and without Python.
Tested clr with Windows before and after adding missing C++ bits.