[release/8.0-preview1] [QUIC] Fix conditions to bin place msquic.dll for Windows builds #81492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #81490 to release/8.0-preview1 /cc @ManickaP Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
github-actions
bot
force-pushed
the
backport/pr-81490-to-release/8.0-preview1
branch
from
2812e7b
to
2ad2199
Compare
carlossanlop
approved these changes
Feb 1, 2023
|
Tactics approved it in the Preview1 chat, I'll add the label. Assuming the CI passes, I will merge. |
carlossanlop
added
Servicing-approved
|
CI failures are unrelated:
Merging now. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #81490 to release/8.0-preview1
Fixes #81447
/cc @ManickaP
Customer Impact
There's no QUIC nor HTTP/3 support on Windows (specifically Windows 11 as older versions were never supported) without this fix. Applies to both client and server scenarios.
Testing
Added test checking the presence of msquic.dll on supported Windows versions via
QuicListener/QuicConnection.IsSupported. Note that this test is currently failing on main (where this fix isn't merged yet) in #81481.Risk
Low as we tested locally, we're adding test with this PR and the change only re-introduces msquic.dll to the released .NET bits as was with previous versions.